Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCIceComponent should use lowercase strings #636

Closed
aboba opened this issue Jan 12, 2017 · 0 comments
Closed

RTCIceComponent should use lowercase strings #636

aboba opened this issue Jan 12, 2017 · 0 comments
Assignees
@aboba
Labels
1.0 compatibility issue PR exists

Comments

@aboba
Copy link
Contributor

aboba commented Jan 12, 2017 •
edited

The convention is to use lowercase values for enum and we have already applied this for RTCIceProtocol.

Related: WebRTC 1.0 Issue w3c/webrtc-pc#992
@aboba aboba self-assigned this Jan 12, 2017
@aboba aboba changed the title RTCIceComponent should use lowercase strings RTCIceComponent and RTCIceProtocol should use lowercase strings Jan 12, 2017
@aboba aboba changed the title RTCIceComponent and RTCIceProtocol should use lowercase strings RTCIceComponent should use lowercase strings Jan 12, 2017
aboba added a commit that referenced this issue Jan 12, 2017
@aboba
RTCIceComponent to use lower case
f031510 
Fix for Issue #636
@aboba aboba mentioned this issue Jan 12, 2017
Merged
@aboba aboba closed this as completed Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aboba aboba

Labels
1.0 compatibility issue PR exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aboba