New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section 2.5.1 Fingerprint attribute #64

Closed
aboba opened this Issue Apr 16, 2014 · 4 comments

Comments

Projects
None yet
4 participants
@aboba
Copy link
Contributor

aboba commented Apr 16, 2014

The current editor's draft has a typo in the description of the fingerprint attribute in Section 2.5.1:

fingerprint of type sequence
attribute" defined in [RFC4572].

This should probably say:
"The fingerprint attribute is a sequence of DOMStrings, each containing a hash-function algorithm and fingerprint, in the syntax defined in [RFC4572] Section 5."

@juberti

This comment has been minimized.

Copy link

juberti commented Apr 17, 2014

Should this not be a structured object with .algorithm and .value members?

@martinthomson

This comment has been minimized.

Copy link
Member

martinthomson commented Apr 17, 2014

Agree with Justin. I'd rather not use DOMString either. ArrayBuffer seems most appropriate for binary data. Producing strings from those is pretty straightforward.

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Apr 29, 2014

How about this?

dictionary RTCDtlsParameters {
RTCDtlsRole role = "auto";
sequence fingerprint;
};
dictionary RTCDtlsFingerprint {
DOMString algorithm;
DOMString value;
};

Dictionary RTCDtlsFingerprint Members

algorithm of type DOMString
One of the the hash function algorithms defined in the 'Hash function Textual Names' registry, initially specified in [RFC4572] Section 8.

value of type DOMString
The value of the certificate fingerprint, expressed utilizing the syntax of 'fingerprint' in [RFC4572] Section 5.

@robin-raymond

This comment has been minimized.

Copy link
Contributor

robin-raymond commented Apr 29, 2014

@robin-raymond robin-raymond added the 1.1 label Apr 29, 2014

robin-raymond pushed a commit to robin-raymond/ortc that referenced this issue Apr 29, 2014

Robin Raymond
- Fixes for error handling, as described in w3c#26
- Support for contributing sources removed (re-classified as a 1.2 feature), as described in w3c#27
- Cleanup of DataChannel construction, as described in w3c#60
- Separate proposal on simulcast/layering, as described in w3c#61
- Separate proposal on quality, as described in w3c#62
- Fix for TCP candidate type, as described in w3c#63
- Fix to the fingerprint attribute, as described in w3c#64
- Fix to RTCRtpFeatures, as described in w3c#65
- Support for retrieval of remote certificates, as described in w3c#67
- Support for ICE error handling, described in w3c#68
- Support for Data Channel send rate control, as described in w3c#69
- Support for capabilities and settings, as described in w3c#70
- Removal of duplicate RTCRtpListener functionality, as described in w3c#71
- ICE gathering state added, as described in w3c#72
- Removed ICE role from the ICE transport constructor, as described in w3c#73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment