Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCRtpCapabilities.fecMechanisms appears redundant #655

Closed
taylor-b opened this Issue Feb 4, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@taylor-b
Copy link

taylor-b commented Feb 4, 2017

"red", "ulpfec" and "flexfec" already appear in the capabilities as codecs, so fecMechanisms doesn't seem to be providing any additional information.

Or, was the intention to allow for additional error correction mechanisms to be added in the future that don't appear as codecs?

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Feb 5, 2017

@taylor-b RTCRtpCapabilities.codecs[] includes entries for "red", "ulpfec" and "flexfec". However, this info by itself does not appear to be sufficient for the shim. For example, if "red" and "ulpfec" are advertised, what does this imply about the supported combinations? For example, can "ulpfec" be used by itself, or is it only supported along with RED? So that is why fecMechanisms includes "red+ulpfec" as a mechanism. If the only entries in fecMechanisms were "red", "ulpfec" and "flexfec" then I agree it would be redundant.

@robin-raymond Can you comment on how ORTC lib deals with fecMechanisms?

@taylor-b

This comment has been minimized.

Copy link
Author

taylor-b commented Feb 6, 2017

@aboba Ah, I see. Chrome's implementation will only use ulpfec with RED, I believe; what does Edge do? We could simply mandate that implementations advertising support for RED and ulpfec support the combination.

But, given your explanation, I'm fine with things as-is. I just didn't realize what the intent was.

aboba added a commit that referenced this issue Feb 17, 2017

@aboba aboba added the PR exists label Feb 17, 2017

@aboba aboba closed this Mar 15, 2017

@ibc

This comment has been minimized.

Copy link
Contributor

ibc commented Mar 16, 2017

BTW can "ulpfec" work without RED?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.