Skip to content

/ ortc

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTMF: sync with WebRTC 1.0 #719

Closed
aboba opened this issue Jul 10, 2017 · 2 comments
Closed

DTMF: sync with WebRTC 1.0 #719

aboba opened this issue Jul 10, 2017 · 2 comments
Assignees
@aboba
Labels
1.0 compatibility issue PR exists

Comments

@aboba
Copy link
Contributor

@aboba aboba commented Jul 10, 2017 •
edited

The following merged WebRTC 1.0 PRs may relate to ORTC as well:

w3c/webrtc-pc#1373 (DTMF playout algorithm for comma)
w3c/webrtc-pc#1338 (insertDTMF replaces tone buffer)
w3c/webrtc-pc#1335 (typo in DTMF playout steps)
w3c/webrtc-pc#1298 (intertone gap maximum)
@aboba aboba self-assigned this Jul 10, 2017
@robin-raymond
Copy link
Contributor

@robin-raymond robin-raymond commented Jul 18, 2017

WebRTC insertDTMF has a race condition since the tonebuffer can change dynamically depending when it was read vs calling the insert.
aboba added a commit that referenced this issue Jul 24, 2017
@aboba
DTMF sync with WebRTC 1.0
bba15d3 
Fix for Issue #719
@aboba aboba mentioned this issue Jul 24, 2017
Closed
@aboba aboba added the PR exists label Jul 25, 2017
@aboba
Copy link
Contributor Author

@aboba aboba commented Jul 25, 2017

Opened a separate Issue #732 to deal with the race condition.
aboba added a commit that referenced this issue Jul 26, 2017
@aboba
DTMF sync with WebRTC 1.0
d46a2bc 
Fix for Issue Fix for Issue #719

Rebase of PR #729
@aboba aboba mentioned this issue Jul 26, 2017
Merged
@aboba aboba closed this Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aboba aboba

Labels
1.0 compatibility issue PR exists
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@aboba @robin-raymond