New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTMF: sync with WebRTC 1.0 #719

Closed
aboba opened this Issue Jul 10, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@aboba
Contributor

aboba commented Jul 10, 2017

The following merged WebRTC 1.0 PRs may relate to ORTC as well:

w3c/webrtc-pc#1373 (DTMF playout algorithm for comma)
w3c/webrtc-pc#1338 (insertDTMF replaces tone buffer)
w3c/webrtc-pc#1335 (typo in DTMF playout steps)
w3c/webrtc-pc#1298 (intertone gap maximum)

@aboba aboba self-assigned this Jul 10, 2017

@robin-raymond

This comment has been minimized.

Contributor

robin-raymond commented Jul 18, 2017

WebRTC insertDTMF has a race condition since the tonebuffer can change dynamically depending when it was read vs calling the insert.

aboba added a commit that referenced this issue Jul 24, 2017

@aboba aboba added the PR exists label Jul 25, 2017

@aboba

This comment has been minimized.

Contributor

aboba commented Jul 25, 2017

Opened a separate Issue #732 to deal with the race condition.

aboba added a commit that referenced this issue Jul 26, 2017

DTMF sync with WebRTC 1.0
Fix for Issue Fix for Issue #719

Rebase of PR #729

@aboba aboba closed this Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment