Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDTMF: sync with WebRTC 1.0 #719
Comments
aboba
added
the
1.0 compatibility issue
label
Jul 10, 2017
aboba
self-assigned this
Jul 10, 2017
This comment has been minimized.
This comment has been minimized.
|
WebRTC insertDTMF has a race condition since the tonebuffer can change dynamically depending when it was read vs calling the insert. |
added a commit
that referenced
this issue
Jul 24, 2017
aboba
added
the
PR exists
label
Jul 25, 2017
This comment has been minimized.
This comment has been minimized.
|
Opened a separate Issue #732 to deal with the race condition. |
added a commit
that referenced
this issue
Jul 26, 2017
aboba
closed this
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
aboba commentedJul 10, 2017
•
edited
The following merged WebRTC 1.0 PRs may relate to ORTC as well:
w3c/webrtc-pc#1373 (DTMF playout algorithm for comma)
w3c/webrtc-pc#1338 (insertDTMF replaces tone buffer)
w3c/webrtc-pc#1335 (typo in DTMF playout steps)
w3c/webrtc-pc#1298 (intertone gap maximum)