Skip to content

/ ortc

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTMF Examples: Race Condition #732

Closed
aboba opened this issue Jul 25, 2017 · 0 comments
Closed

DTMF Examples: Race Condition #732

aboba opened this issue Jul 25, 2017 · 0 comments
Labels
PR exists

Comments

@aboba
Copy link
Contributor

@aboba aboba commented Jul 25, 2017 •
edited

From Robin: insertDTMF has a race condition since the tonebuffer can change dynamically depending when it was read vs calling insertDTMF.

[BA] This appears in Examples 19, 20 and possibly 21.

Related WebRTC PR: w3c/webrtc-pc#1337 (fix DTMF examples)
@aboba aboba mentioned this issue Jul 25, 2017
Closed
aboba added a commit that referenced this issue Sep 18, 2017
@aboba
DTMF example problems
fdfa561 
Fix for Issue #732
Related WebRTC 1.0 PR: w3c/webrtc-pc#1607
@aboba aboba mentioned this issue Sep 18, 2017
Merged
@aboba aboba added the PR exists label Sep 18, 2017
@aboba aboba closed this Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR exists
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@aboba