Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should "numChannels" become "channels" as in WebRTC? #738

Closed
ibc opened this issue Aug 5, 2017 · 2 comments
Closed

Should "numChannels" become "channels" as in WebRTC? #738

ibc opened this issue Aug 5, 2017 · 2 comments
Assignees
@ibc
Labels
1.0 compatibility issue

Comments

@ibc
Copy link
Contributor

ibc commented Aug 5, 2017

In WebRTC RTCRtpCodecParameters there is channels rather than numChannels.

Should ORTC update it to be in sync?
@robin-raymond
Copy link
Contributor

@ibc yes, likely we should change in ORTC to match.

@ibc ibc mentioned this issue Aug 6, 2017
Merged
@ibc
Copy link
Contributor Author

ibc commented Aug 6, 2017

Thanks, I've sent a PR for this.

fippo added a commit to otalk/sdp that referenced this issue May 10, 2018
@fippo
add 'channels' to rtpmap parsing/serialization
e803551 
got renamed in w3c/ortc#738
@fippo fippo mentioned this issue May 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibc ibc

Labels
1.0 compatibility issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibc @robin-raymond