fixup Example 5, 6 of getRemoteParameters #239

Closed
wants to merge 0 commits into
from

Projects

None yet

3 participants

@Jxck
Contributor
Jxck commented Sep 15, 2015

close #235

@aboba commented that Example 7 also.
#235 (comment)

but I think Example 7 is fine.

@aboba aboba added the 1.1 label Sep 15, 2015
@aboba
Contributor
aboba commented Sep 15, 2015

Looks good.

On Mon, Sep 14, 2015 at 10:12 PM, Jxck notifications@github.com wrote:

close #235 #235

@aboba https://github.com/aboba commented that Example 7 also.
#235 (comment)
#235 (comment)

but I think Example 7 is fine.

You can view, comment on, or merge this pull request online at:

#239
Commit Summary

  • fixup getRemoteParameters at Example 5
  • fixup getRemoteParameters at Example 6

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#239.

@robin-raymond robin-raymond pushed a commit that referenced this pull request Sep 21, 2015
Robin Raymond Added support for the WebRTC 1.0 certificate management API, as noted…
… in: Issue #195

Added certificate argument to the RTCDtlsTransport constructor, as noted in: Issue #218
Added the "failed" state to RTCDtlsTransportState, as noted in: Issue #219
Changed getNominatedCandidatePair to getSelectedCandidatePair, as noted in: Issue #220
Added support for WebRTC 1.0 RTCIceCredentialType, as noted in: Issue #222
Clarified behavior of createAssociatedGatherer(), as noted in: Issue #223
Changed spelling from "iceservers" to "iceServers" for consistency with WebRTC 1.0, as noted in: Issue #225
Added support for SCTP port numbers, as noted in: Issue #227
Changed "outbound-rtp" to "outboundrtp" within the Statistics API, as noted in: Issue #229
Changed maxPacketLifetime and maxRetransmits from unsigned short to unsigned long, as noted in: Issue #231
Clarified DataChannel negotiation, as noted in: Issue #233
Added getContributingSources() method, as noted in: Issue #236
Fixes to Examples 5 and 6, as noted in: Issue 237 and Issue #239
Fixed cut and paste errors in Example 11, as noted in: Issue #241
674f156
@robin-raymond
Contributor

Should be fixed now. Please review.

@Jxck
Contributor
Jxck commented Sep 24, 2015

its seems good.
actually, too big diff including other fixes, so hard to review..

@Jxck Jxck closed this Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment