Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup Example 5, 6 of getRemoteParameters #239

Closed
wants to merge 0 commits into from
Closed

Conversation

Jxck
Copy link
Contributor

@Jxck Jxck commented Sep 15, 2015

close #235

@aboba commented that Example 7 also.
#235 (comment)

but I think Example 7 is fine.

@aboba aboba added the 1.1 label Sep 15, 2015
@aboba
Copy link
Contributor

aboba commented Sep 15, 2015

Looks good.

On Mon, Sep 14, 2015 at 10:12 PM, Jxck notifications@github.com wrote:

close #235 #235

@aboba https://github.com/aboba commented that Example 7 also.
#235 (comment)
#235 (comment)

but I think Example 7 is fine.

You can view, comment on, or merge this pull request online at:

#239
Commit Summary

  • fixup getRemoteParameters at Example 5
  • fixup getRemoteParameters at Example 6

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#239.

robin-raymond pushed a commit that referenced this pull request Sep 21, 2015
… in: Issue #195

Added certificate argument to the RTCDtlsTransport constructor, as noted in: Issue #218
Added the "failed" state to RTCDtlsTransportState, as noted in: Issue #219
Changed getNominatedCandidatePair to getSelectedCandidatePair, as noted in: Issue #220
Added support for WebRTC 1.0 RTCIceCredentialType, as noted in: Issue #222
Clarified behavior of createAssociatedGatherer(), as noted in: Issue #223
Changed spelling from "iceservers" to "iceServers" for consistency with WebRTC 1.0, as noted in: Issue #225
Added support for SCTP port numbers, as noted in: Issue #227
Changed "outbound-rtp" to "outboundrtp" within the Statistics API, as noted in: Issue #229
Changed maxPacketLifetime and maxRetransmits from unsigned short to unsigned long, as noted in: Issue #231
Clarified DataChannel negotiation, as noted in: Issue #233
Added getContributingSources() method, as noted in: Issue #236
Fixes to Examples 5 and 6, as noted in: Issue 237 and Issue #239
Fixed cut and paste errors in Example 11, as noted in: Issue #241
@robin-raymond
Copy link
Contributor

Should be fixed now. Please review.

@Jxck
Copy link
Contributor Author

Jxck commented Sep 24, 2015

its seems good.
actually, too big diff including other fixes, so hard to review..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no existed API on Example
3 participants