fixup typos seems caused by copy pasted code #241

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@Jxck
Contributor
Jxck commented Sep 15, 2015

on Example11

@aboba
Contributor
aboba commented Sep 15, 2015

Fixed.

On Mon, Sep 14, 2015 at 10:34 PM, Jxck notifications@github.com wrote:

on Example11

You can view, comment on, or merge this pull request online at:

#241
Commit Summary

  • fixup typos seems caused by copy pasted code

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#241.

@Jxck
Contributor
Jxck commented Sep 16, 2015

what fixed means ?
merged this pr to some branch which you don't pushed to this repo yet ?

@Jxck
Contributor
Jxck commented Sep 19, 2015

why you don't click merge button ? or push your branch to master of this repository ?
I'am going to send more PR after this, but it's hard to continue contributing without knowing whether this PR was accepted or not.
and you can close this issue after merging or denying this PR.
thats easy for me to see the status of whats going.

@robin-raymond
Contributor

@Jxck agreed. We should be pushing more frequently so the current mods can be up-to-date in the repo. For now, we've manually merged.

@robin-raymond robin-raymond pushed a commit that referenced this pull request Sep 21, 2015
Robin Raymond Added support for the WebRTC 1.0 certificate management API, as noted…
… in: Issue #195

Added certificate argument to the RTCDtlsTransport constructor, as noted in: Issue #218
Added the "failed" state to RTCDtlsTransportState, as noted in: Issue #219
Changed getNominatedCandidatePair to getSelectedCandidatePair, as noted in: Issue #220
Added support for WebRTC 1.0 RTCIceCredentialType, as noted in: Issue #222
Clarified behavior of createAssociatedGatherer(), as noted in: Issue #223
Changed spelling from "iceservers" to "iceServers" for consistency with WebRTC 1.0, as noted in: Issue #225
Added support for SCTP port numbers, as noted in: Issue #227
Changed "outbound-rtp" to "outboundrtp" within the Statistics API, as noted in: Issue #229
Changed maxPacketLifetime and maxRetransmits from unsigned short to unsigned long, as noted in: Issue #231
Clarified DataChannel negotiation, as noted in: Issue #233
Added getContributingSources() method, as noted in: Issue #236
Fixes to Examples 5 and 6, as noted in: Issue 237 and Issue #239
Fixed cut and paste errors in Example 11, as noted in: Issue #241
674f156
@robin-raymond
Contributor

Should be fixed now. Please review.

@Jxck
Contributor
Jxck commented Sep 24, 2015

LGTM.
please separate the commit for each issue, or use merge pull request on github.

@Jxck Jxck closed this Sep 29, 2015
@robin-raymond robin-raymond pushed a commit that referenced this pull request Oct 6, 2015
Robin Raymond - Clarified behavior of RTCDataChannel.send(), as noted in:
#240

- Fixed typos in Example 11, as noted in:
#241
#248

- Added text relating to RTCDataChannel exceptions and errors, as noted in:
#242

- Reconciliation of RTCRtpEncodingParameters dictionary with WebRTC 1.0, as noted in:
#249
e395344
@Jxck Jxck deleted the Jxck:pr branch Oct 15, 2015
@Jxck Jxck added a commit to Jxck/ortc that referenced this pull request Oct 15, 2015
@Jxck Robin Raymond + Jxck - Clarified behavior of RTCDataChannel.send(), as noted in:
w3c#240

- Fixed typos in Example 11, as noted in:
w3c#241
w3c#248

- Added text relating to RTCDataChannel exceptions and errors, as noted in:
w3c#242

- Reconciliation of RTCRtpEncodingParameters dictionary with WebRTC 1.0, as noted in:
w3c#249
5be6f84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment