From b61cc325f9800dc47cf36131eb475c908960907b Mon Sep 17 00:00:00 2001 From: Bernard Aboba Date: Mon, 22 Jan 2018 22:23:04 -0800 Subject: [PATCH 1/3] Revise sender/receiver setTransport() method Fix for Issue https://github.com/w3c/ortc/issues/804 --- index.html | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/index.html b/index.html index 62c2fc9..263f4d2 100644 --- a/index.html +++ b/index.html @@ -3027,12 +3027,13 @@

Methods

be the arguments to this method.

  • -

    If setTransport() is called with no arguments, - or if withTransport is unset, throw an - InvalidParameters.

    +

    If withTransport is null and + withRtcpTransport is set, throw an + OperationError and abort these steps.

  • -

    If withTransport.transport.component is +

    If withTransport is set and + withTransport.transport.component is rtcp, throw an InvalidParameters.

  • @@ -3052,8 +3053,10 @@

    Methods

  • Set transport to withTransport and - rtcpTransport to withRtcpTransport - (if provided) and seamlessly send over the new transport(s).

    + rtcpTransport to withRtcpTransport.

    +
    • +

    If transport is set and transport.state + is not failed, seamlessly send over the new transport(s).

    From 884c3d9867621622763ebaf34c6f173e6d96b3d4 Mon Sep 17 00:00:00 2001 From: Bernard Aboba Date: Mon, 22 Jan 2018 22:30:18 -0800 Subject: [PATCH 2/3] Add receiver steps --- index.html | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/index.html b/index.html index 263f4d2..ba6cb55 100644 --- a/index.html +++ b/index.html @@ -3055,8 +3055,8 @@

    Methods

    Set transport to withTransport and rtcpTransport to withRtcpTransport.

    -

    If transport is set and transport.state - is not failed, seamlessly send over the new transport(s).

    +

    If transport is set and transport.state + is not failed, seamlessly send over the new transport(s).

    @@ -3661,19 +3661,22 @@

    Methods

    Let receiver be the RTCRtpReceiver object on which setTransport() is invoked.

    -
  • If receiver's [[\RtpReceiverIsStopped]] slot is true, - throw an InvalidStateError.
    • +
  • +

    If receiver's [[\RtpReceiverIsStopped]] slot is true, + throw an InvalidStateError.

    +

  • Let withTransport and withRtcpTransport be the arguments to this method.

  • -

    If setTransport() is called with no arguments, - or if withTransport is unset, throw an - InvalidParameters.

    +

    If withTransport is null and + withRtcpTransport is set, throw an + OperationError and abort these steps.

  • -

    If withTransport.transport.component is +

    If withTransport is set and + withTransport.transport.component is rtcp, throw an InvalidParameters.

  • @@ -3692,9 +3695,12 @@

    Methods

    closed, throw an InvalidStateError.

  • -

    Replace transport (if set) with withTransport and - rtcpTransport (if set) with withRtcpTransport and - seamlessly receive over the new transport(s).

    +

    Set transport to withTransport and + rtcpTransport to withRtcpTransport.

    +
    • +

    If transport is set and transport.state + is not failed, seamlessly receive over the new transport(s).

    +
    From 2ad92d9702cb3a772eb9b801f77ed42240895075 Mon Sep 17 00:00:00 2001 From: Bernard Aboba Date: Wed, 24 Jan 2018 19:59:26 -0800 Subject: [PATCH 3/3] Remove drive-by change --- index.html | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/index.html b/index.html index ba6cb55..01317a5 100644 --- a/index.html +++ b/index.html @@ -3661,10 +3661,8 @@

    Methods

    Let receiver be the RTCRtpReceiver object on which setTransport() is invoked.

    -
  • -

    If receiver's [[\RtpReceiverIsStopped]] slot is true, - throw an InvalidStateError.

    -
    • +
  • If receiver's [[\RtpReceiverIsStopped]] slot is true, + throw an InvalidStateError.

  • Let withTransport and withRtcpTransport be the arguments to this method.