Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct reference of Page Visibility to top level browsing context #45

Closed
wants to merge 2 commits into from

Conversation

@toddreifsteck
Copy link
Member

@toddreifsteck toddreifsteck commented Jun 12, 2019

This should fix #41

@rniwa @jyasskin, can you take a look?


Preview | Diff

@toddreifsteck
Copy link
Member Author

@toddreifsteck toddreifsteck commented Jun 12, 2019

Also resolves #44

Loading

@yoavweiss
Copy link
Contributor

@yoavweiss yoavweiss commented Jul 15, 2019

@toddreifsteck - can you resolve the conflicts here?

Loading

@siusin
Copy link
Contributor

@siusin siusin commented Aug 19, 2019

@yoavweiss
Conflicts resolved.

Loading

<li>If the {{Document/defaultView}} of |doc| is `null`, return
{{VisibilityState["hidden"]}}.
<li>Return "hidden" if the <a>context object</a>is not [=Document/fully active=]</li>
<li>Let |doc:Document| be the <a>active document</a> of the top level
Copy link

@rniwa rniwa Aug 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's "top-level browsing context". We should link it to https://html.spec.whatwg.org/#top-level-browsing-context also.

Loading

<li>Return "hidden" if the <a>context object</a>is not [=Document/fully active=]</li>
<li>Let |doc:Document| be the <a>active document</a> of the top level
browsing context of the <a>context object</a>'s [=Document/browsing context=].</li>
<li>If the {{Document/defaultView}} of |doc| is `null`,
Copy link

@rniwa rniwa Aug 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, this is impossible. Because a document being fully active implies the document has a browsing context and each browsing context is associated with a WindowProxy. See https://html.spec.whatwg.org/#windowproxy

Loading

@rniwa
Copy link

@rniwa rniwa commented Aug 20, 2019

Here's my suggestion. Just say:
Return "hidden" if the context object is not fully active.

Because being fully active is defined as having a non-null browsing context, which is either itself the top-level browsing context or its ancestor browsing contexts are also fully active, there is no need to repeat that definition.

Loading

@toddreifsteck
Copy link
Member Author

@toddreifsteck toddreifsteck commented Sep 17, 2019

@rniwa Please see #46 which includes these fixes.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants