Skip to content
This repository has been archived by the owner. It is now read-only.

Chore: export definitions #54

Merged
merged 4 commits into from May 20, 2020
Merged

Chore: export definitions #54

merged 4 commits into from May 20, 2020

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Sep 8, 2019

Don't merge yet! Working on ReSpec support for this.

This will allow other ReSpec/BikeShed specifications reference the "visible", "hidden", and "visibility states" concepts, by doing:

  • [=Document/visibility state=]
  • [=Document/hidden=]
  • [=Document/visible=]

This is important for other specs, like Screen Orientation, that depend heavily on being able to check visibility state of a Document.


Preview | Diff

@toddreifsteck
Copy link
Member

@toddreifsteck toddreifsteck commented Sep 17, 2019

@marcoscaceres What signal will tell us this is ready to merge?

@marcoscaceres
Copy link
Member Author

@marcoscaceres marcoscaceres commented Sep 17, 2019

I'll ping back here - high priority for me to fix after TPAC.

@marcoscaceres
Copy link
Member Author

@marcoscaceres marcoscaceres commented Sep 17, 2019

Relevant WIP on the ReSpec side: w3c/respec#2508

index.html Outdated Show resolved Hide resolved
@igrigorik
Copy link
Member

@igrigorik igrigorik commented Dec 6, 2019

@marcoscaceres is this good to review / merge?

@marcoscaceres
Copy link
Member Author

@marcoscaceres marcoscaceres commented Dec 11, 2019

@marcoscaceres is this good to review / merge?

It's ok to review, but not to merge yet ... still working on the ReSpec side... but promise this will make a huge difference to specs relying on this spec - so I kindly ask for your patience!

@plehegar plehegar self-requested a review Jan 30, 2020
@kenchris
Copy link

@kenchris kenchris commented May 19, 2020

any update on this, we need it for screen fold angle api as well

@marcoscaceres
Copy link
Member Author

@marcoscaceres marcoscaceres commented May 19, 2020

Oh, we are super close! @sidvishnoi, all ready?

@sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented May 19, 2020

Yep. It's ready just today!

@marcoscaceres marcoscaceres requested a review from siusin May 19, 2020
Marcos Cáceres and others added 3 commits May 19, 2020
Co-Authored-By: Sid Vishnoi <sidvishnoi8@gmail.com>
@marcoscaceres
Copy link
Member Author

@marcoscaceres marcoscaceres commented May 19, 2020

Rebased ... @siusin, this should be ready to go. Only ReSpec usage changes.

@siusin
Copy link
Contributor

@siusin siusin commented May 20, 2020

Ok, thanks @marcoscaceres and @sidvishnoi !

siusin
siusin approved these changes May 20, 2020
@siusin siusin merged commit 506584e into gh-pages May 20, 2020
1 check passed
@marcoscaceres marcoscaceres deleted the exports branch May 20, 2020
@marcoscaceres
Copy link
Member Author

@marcoscaceres marcoscaceres commented May 20, 2020

Ok, next hard question for @plehegar and @siusin... how can we get this latest version on TR/? 😅

@plehegar
Copy link
Member

@plehegar plehegar commented May 20, 2020

I guess as a WD or a CR. @yoavweiss , the spec has been a Proposed Recommendation forever. I don't think we can hope to push it to REC anytime soon. ok to go back to CR?

@yoavweiss
Copy link
Contributor

@yoavweiss yoavweiss commented May 20, 2020

I don't think there's a lot of work left, but at the same time, going back to CR is not awful, so WFM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants