Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove concept of types, supportedTypes, BasicCardType enum #62

Merged
merged 3 commits into from Nov 15, 2018

Conversation

@marcoscaceres
Copy link
Member

commented Nov 1, 2018

closes #59

The following tasks have been completed:

Implementation commitments:

  • Safari (link to issue)
  • Chrome (link to issue)
  • Firefox
  • Edge (public signal)

Preview | Diff

@marcoscaceres marcoscaceres requested a review from ianbjacobs Nov 1, 2018

@ianbjacobs
Copy link
Contributor

left a comment

Only one editorial suggestion; otherwise good to go.

index.html Outdated Show resolved Hide resolved
@marcoscaceres

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2018

@rsolomakhin you probably saw, I sent a bunch of pull requests updating the tests. I hacked up your handler tests, so please make sure I didn't screw them up :)

@zouhir, heads up on the Microsoft side.

@rsolomakhin

This comment has been minimized.

Copy link
Collaborator

commented Nov 1, 2018

ACK

@zouhir

This comment has been minimized.

Copy link
Collaborator

commented Nov 4, 2018

👍

@marcoscaceres marcoscaceres referenced this pull request Nov 4, 2018
@marcoscaceres

This comment has been minimized.

Copy link
Member Author

commented Nov 5, 2018

Oki, sent removal patch on the Gecko side...

@ianbjacobs

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

@ianbjacobs

This comment has been minimized.

Copy link
Contributor

commented Nov 5, 2018

@marcoscaceres,

I believe there are libraries that support Basic Card. We want to understand the impact of deprecating this feature on that deployed software. Perhaps the editors can reach consensus on appropriate browser behavior when they encounter this deprecated feature.

Thanks!

@marcoscaceres

This comment has been minimized.

Copy link
Member Author

commented Nov 5, 2018

Libraries would be unaffected in terms of behavior - passing in supportedTypes is ignored. And the spec makes no guarantees that the returned card is of the requested network or type, so nothing really changes there: the payment processor still needs to check that the user didn’t provide a bogus card.

@marcoscaceres

This comment has been minimized.

Copy link
Member Author

commented Nov 6, 2018

Blocked on CFC until 15th of November.

@marcoscaceres marcoscaceres removed the blocked label Nov 14, 2018

@marcoscaceres marcoscaceres merged commit 35ab09e into gh-pages Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@marcoscaceres marcoscaceres deleted the remove_supportedTypes branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.