Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a clear definition of when a UA should display controls in a PiP window #119

Closed
scottlow opened this issue Mar 6, 2019 · 2 comments

Comments

@scottlow
Copy link

commented Mar 6, 2019

The spec today states the following with respect to a UA displaying controls that map to MediaSession actions:

The API will have to be used with the MediaSession API for customizing the available controls on the Picture-in-Picture window.

... the user agent MAY expose Picture-in-Picture window controls that change video playback state (e.g., pause).

It makes sense for a play/pause control to be continually shown in a PiP window, however, for the remaining actions (seekbackward, seekforward, previoustrack, nexttrack, and skipad), it seems like there would be value in specifying that UAs which choose to display controls should either hide or disable UI elements that map to actions that do not have a MediaSessionActionHandler associated with them.

@beaufortfrancois

This comment has been minimized.

Copy link
Collaborator

commented Mar 6, 2019

It will be hard to add web platform tests for those but I'd be happy to reconsider defining whether controls should be displayed in the PiP window in this spec.

Note that in Chrome for instance, we have special rules for the play/pause button. If video is a mediastream or has infinite duration, we don't show it by default unless MediaSession actions are set for "play" and "pause".
Moreover, we currently show next and previous tracks when MediaSession actions are set for "nexttrack" and "previoustrack" but other user agents may want to always show them in a disabled state.

WDYT @mounirlamouri @jernoble

@scottlow

This comment has been minimized.

Copy link
Author

commented Sep 20, 2019

Per discussion at TPAC 2019, we agreed that this behavior should be left up to the UA.

@scottlow scottlow closed this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.