Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy mouse event: fixed a missing text & a note #151

Merged
merged 2 commits into from Nov 8, 2016

Conversation

Projects
None yet
3 participants
@mustaqahmed
Copy link
Contributor

commented Oct 20, 2016

Fixes #117.

index.html Outdated
@@ -883,7 +883,7 @@
<p>Whenever a user agent is to dispatch a pointer event for a device that supports hover, it SHOULD run the following steps:</p>
<ol>
<li>If the <code>isPrimary</code> property for the pointer event to be dispatched is <code>false</code> then dispatch the pointer event and terminate these steps.</li>
<li>If the pointer event to be is dispatched is <code>pointerdown</code>, <code>pointerup</code> or <code>pointermove</code>, dispatch compatibility mouse transition events as described in <a>Tracking the effective position of the legacy mouse pointer</a>.</li>
<li>If the pointer event to be is dispatched is <code>pointerdown</code>, <code>pointerup</code> or <code>pointermove</code>, or a <code>pointerleave</code> event at the <code>window</code>, dispatch compatibility mouse transition events as described in <a>Tracking the effective position of the legacy mouse pointer</a>.</li>

This comment has been minimized.

Copy link
@patrickhlauke

patrickhlauke Oct 20, 2016

Member

i'd change the "or" after <code>pointerup</code> to a comma

This comment has been minimized.

Copy link
@mustaqahmed

mustaqahmed Oct 27, 2016

Author Contributor

We need to avoid the wrong interpretation that all 4 event types are targeted to window. In the latest path I did a simple rephrasing to emphasize that only the pointerleave event is targeted to window. Does it look better now?

index.html Outdated
@@ -909,7 +909,7 @@
<ol>
<li>If the <code>isPrimary</code> property for the pointer event to be dispatched is <code>false</code> then dispatch the pointer event and terminate these steps.</li>
<li>If the pointer event to be dispatched is <code>pointerover</code> and the <code>pointerdown</code> event has not yet been dispatched for this pointer, then fire a <code>mousemove</code> event (for compatibility with legacy mouse-specific code).</li>
<li>If the pointer event to be is dispatched is <code>pointerdown</code>, <code>pointerup</code> or <code>pointermove</code>, dispatch compatibility mouse transition events as described in <a>Tracking the effective position of the legacy mouse pointer</a>.</li>
<li>If the pointer event to be is dispatched is <code>pointerdown</code>, <code>pointerup</code> or <code>pointermove</code>, or a <code>pointerleave</code> event at the <code>window</code>, dispatch compatibility mouse transition events as described in <a>Tracking the effective position of the legacy mouse pointer</a>.</li>

This comment has been minimized.

Copy link
@patrickhlauke

patrickhlauke Oct 20, 2016

Member

i'd change the "or" after <code>pointerup</code> to a comma

This comment has been minimized.

Copy link
@mustaqahmed

mustaqahmed Oct 27, 2016

Author Contributor

Ditto.

@RByers

This comment has been minimized.

Copy link
Contributor

commented Oct 27, 2016

LGTM modulo Patrick's suggestion (which I agree with).

@mustaqahmed

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2016

ptal: I addressed Patrick's concerns in a slightly different way.

Since my comments on the old patch seems hidden above, I am copy-pasting my response here:

We need to avoid the wrong interpretation that all 4 event types are targeted to window. In the latest patch I did a simple rephrasing to emphasize that only the pointerleave event is targeted to window. Does it look better now?

@patrickhlauke patrickhlauke merged commit 11973eb into w3c:gh-pages Nov 8, 2016

@patrickhlauke

This comment has been minimized.

Copy link
Member

commented Nov 8, 2016

LGTM thanks. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.