Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the touch-action processing model for zoom scenarios #24

Merged
merged 1 commit into from Dec 1, 2015

Conversation

Projects
None yet
1 participant
@RByers
Copy link
Contributor

commented Oct 22, 2015

It's incorrect to consider the touch-action values only up to the nearest
ancestor that supports ANY default touch behavior. Eg. in Edge you can
disable double-tap to zoom across an entire page (including any iframes
or other scrolling elements) by applying 'touch-action: manipulation' to
the html element. See http://jsbin.com/tipure/ and http://jsbin.com/jucuna.
This is issue #19.

This change also moves the core processing model details up to
above the specific value definitions to make it easier to follow
without getting lost in all the value-specific notes.

Fix the touch-action processing model for zoom scenarios
It's incorrect to consider the touch-action values only up to the nearest
ancestor that supports ANY default touch behavior.  Eg. in Edge you can
disable double-tap to zoom across an entire page (including any iframes
or other scrolling elements) by applying 'touch-action: manipulation' to
the html element.  See http://jsbin.com/tipure/ and http://jsbin.com/jucuna.
This is issue #19.

This change also moves the core processing model details up to
above the specific value definitions to make it easier to follow
without getting lost in all the value-specific notes.
@RByers

This comment has been minimized.

Copy link
Contributor Author

commented Oct 22, 2015

@jacobrossi I agonized over this text to try to be precise while also avoiding specific gesture details. After an hour, this was the best I could come up with. Do you think it's an improvement?

I'd like to add a web-platform-test case for this, but since which elements support "non-continuous zooming" is out of scope of the spec, I guess I can't - right? Hopefully the jsbin demos are good enough.

Now to fix blink....

@RByers

This comment has been minimized.

Copy link
Contributor Author

commented Oct 28, 2015

In particular, here's the relevant text (since I also foolishly shifted some things around in the same CL):

A touch behavior is supported if allowed by the touch-action properties of all elements between the hit tested element and it's nearest ancestor with the default touch behavior (including both the hit tested element and the element with the default touch behavior).

@RByers

This comment has been minimized.

Copy link
Contributor Author

commented Dec 1, 2015

I talked with @jacobrossi offline and he agreed that (while not perfect) this was definitely a step in the right direction and we should just land it and continue to iterate.

RByers added a commit that referenced this pull request Dec 1, 2015

Merge pull request #24 from RByers/touch-action-manip-fix
Fix the touch-action processing model for zoom scenarios

@RByers RByers merged commit 851444f into w3c:gh-pages Dec 1, 2015

@RByers RByers deleted the RByers:touch-action-manip-fix branch Aug 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.