Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boundary events in implicit capture scenarios #251

Merged

Conversation

@NavidZ
Copy link
Member

commented Apr 19, 2018

closes #173

@NavidZ NavidZ requested review from patrickhlauke and smaug---- Apr 19, 2018

@NavidZ

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2018

index.html Outdated
for the <code>pointerId</code> of the <code>pointerup</code> or <code>pointercancel</code> event that was just dispatched,
and then run <a href="#process-pending-pointer-capture">Process Pending Pointer Capture</a> steps to fire <code>lostpointercapture</code> if necessary.
After running <a href="#process-pending-pointer-capture">Process Pending Pointer Capture</a> steps,
if the pointer supports hover user agent MUST also send corresponding boundary events if necessary to reflect the current position of the pointer with no capture.

This comment has been minimized.

Copy link
@patrickhlauke

patrickhlauke Apr 24, 2018

Member

"pointer supports hover, the user agent MUST"

index.html Outdated
@@ -837,7 +837,14 @@ <h2><dfn>Implicit Pointer Capture</dfn></h2>
</section>
<section>
<h3>Implicit Release of Pointer Capture</h3>
<p>Immediately after firing the <code>pointerup</code> or <code>pointercancel</code> events, a user agent MUST clear the <a>pending pointer capture target override</a> for the <code>pointerId</code> of the <code>pointerup</code> or <code>pointercancel</code> event that was just dispatched, and then run <a href="#process-pending-pointer-capture">Process Pending Pointer Capture</a> steps to fire <code>lostpointercapture</code> if necessary.</p>
<p>

This comment has been minimized.

Copy link
@patrickhlauke

patrickhlauke Apr 24, 2018

Member

a minor thing, but maybe worth not leaving <p> and </p> hanging on their own lines

@mustaqahmed
Copy link
Contributor

left a comment

Looks good. Requesting a minor tweak to make the section consistent.

index.html Outdated
and then run <a href="#process-pending-pointer-capture">Process Pending Pointer Capture</a> steps to fire <code>lostpointercapture</code> if necessary.
After running <a href="#process-pending-pointer-capture">Process Pending Pointer Capture</a> steps,
if the pointer supports hover, user agent MUST also send corresponding boundary events if necessary
to reflect the current position of the pointer with no capture. </p>
<p>If the user agent supports firing the <code>click</code> event (see <a title="compatibility mouse events" href="#dfn-compatibility-mouse-events">compatibility mouse events</a>) and if in an implicit release scenario both <code>click</code> and <code>lostpointercapture</code> events are fired, <code>click</code> should be fired before <code>lostpointercapture</code>.</p>
<p>When the <a>pointer capture target override</a> is removed from its <code>ownerDocument</code>'s tree,
clear the <a>pending pointer capture target override</a> and <a>pointer capture target override</a> nodes

This comment has been minimized.

Copy link
@mustaqahmed

mustaqahmed Apr 25, 2018

Contributor

Bike-shedding on an old text, sorry: the imperative verb only in this para looks odd. Could you please change it too? Something like:

the pending pointer capture target override and pointer capture target override nodes should be cleared and also a lostpointercapture event corresponding to the captured pointer should be fired.

@patrickhlauke patrickhlauke merged commit 8381126 into w3c:gh-pages Apr 26, 2018

patrickhlauke added a commit that referenced this pull request Apr 26, 2018

Update revision history
to include #251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.