Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer Capture is normative. Fix #269 #270

Merged
merged 2 commits into from Nov 27, 2018

Conversation

@plehegar
Copy link
Member

commented Nov 27, 2018

This section was incorrectly marked informative. Fixes #269

@plehegar plehegar requested a review from patrickhlauke Nov 27, 2018

@patrickhlauke

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

digging way back into a9bbc3c it seems originally the introduction to that section and the figure were informative.

<h1><dfn>Pointer Capture</dfn></h1>	
    <div class="informative">	
        <p>Pointer capture allows ...</p>	
        <figure id="figure_slider">	
            ...
        </figure>	
    </div>	
    	
    <section>	
        <h2>Setting Pointer Capture</h2>
        ....

Wonder if we should go for something similar again, or if we're ok just removing it and going with what you propose here.

@patrickhlauke

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

Thinking about this some more (and looking at similar sections), it's probably fine to go with your proposed change here. There doesn't seem to be any harm in having the intro and examples there not explicitly marked non-normative... @NavidZ @mbrubeck et al, shout if you disagree.

@plehegar

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2018

I added a commit to make the intro to that section informative. It requires a dedicated section but makes it clear.

@NavidZ

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

Looks good to me.

@patrickhlauke patrickhlauke merged commit ec802c8 into gh-pages Nov 27, 2018

@patrickhlauke patrickhlauke deleted the pointer-capture-is-normative branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.