Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover the case when primary pointer is removed #50

Merged
merged 1 commit into from Apr 4, 2016

Conversation

@NavidZ
Copy link
Member

commented Mar 24, 2016

To address #48:

Reword a note in primary pointer section to also cover the
case of primary pointer being removed under the scenarios
that user agent may fire pointer events with no primary one.

@scottgonzalez

This comment has been minimized.

Copy link
Member

commented Mar 24, 2016

Looks good.

@patrickhlauke

This comment has been minimized.

Copy link
Member

commented Mar 24, 2016

LGTM. Rick/Jacob?

index.html Outdated
@@ -375,7 +375,7 @@
<div class="note" id="multiple-primary-pointers">When two or more pointer device types are being used concurrently, multiple pointers (one for each <code>pointerType</code>) are considered primary. For example, a touch contact and a mouse cursor moved simultaneously will produce pointers that are both considered primary.</div>
<div class="note">In the case where there are multiple <a href="#the-primary-pointer">primary pointers</a>,
these pointers will all produce <a>compatibility mouse events</a>.</div>
<div class="note">On some platforms, the primary pointer is determined using all active pointers on the device, including those not targeted at the user agent (e.g. in another application). This means it is possible for the user agent to fire pointer events in which no pointer is marked as a primary pointer. For example, if the first touch interaction is targeted outside the user agent and a secondary (multi-touch) touch interaction is targeted inside the user agent, then the user agent may fire pointer events for the second contact with a value of <code>false</code> for <code>isPrimary</code>.</div>
<div class="note">In some cases, it is possible for the user agent to fire pointer events in which no pointer is marked as a primary pointer. For instance, when there are multiple active pointers of a particular type like multi-touch and the primary pointer is removed (e.g. it leaves the screen). Also on some platforms, the primary pointer is determined using all active pointers on the device, including those not targeted at the user agent (e.g. in another application). For example, if the first touch interaction is targeted outside the user agent and a secondary (multi-touch) touch interaction is targeted inside the user agent, then the user agent may fire pointer events for the second contact with a value of <code>false</code> for <code>isPrimary</code>.</div>

This comment has been minimized.

Copy link
@mustaqahmed

mustaqahmed Mar 29, 2016

Contributor
  • "For instance, when there are multiple...screen), there will be no primary pointers."
  • I think the use of "for example" within one case of "for instance" should be avoided for clarity, otherwise the second sentence ("For example, ...") in the second example can possibly appear as the overall third example. Should we use bullets? Or does the following sound clearer?
    "... Also on the platforms where the primary pointer is determined using all active pointers on the device (including those targeted at an application other than the user agent), if the first touch interaction is ..."
Navid Zolghadr
Cover the case when primary pointer is removed
Reword a note in primary pointer section to also cover the
case of primary pointer being removed under the scenarios
that user agent may fire pointer events with no primary one.

@NavidZ NavidZ force-pushed the NavidZ:primarypointerremoved branch from 3a2ac5a to f903a90 Mar 29, 2016

@mustaqahmed

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2016

LGTM.

@patrickhlauke patrickhlauke merged commit 00ab102 into w3c:gh-pages Apr 4, 2016

@RByers

This comment has been minimized.

Copy link
Contributor

commented Apr 14, 2016

Sorry for the delay, looks good to me too - thanks!

@NavidZ NavidZ deleted the NavidZ:primarypointerremoved branch Jul 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.