Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #91. Make all pointer events composed events #92

Merged
merged 1 commit into from Jun 30, 2016

Conversation

@hayatoito
Copy link
Member

commented Jun 21, 2016

All pointer events should propagate across Shadow DOM bounaries.
See w3c/webcomponents#513 for details.

@patrickhlauke

This comment has been minimized.

Copy link
Member

commented Jun 21, 2016

as I'm not completely au-fait with what composed events actually are/do, nor if there are any issues with a W3C spec referencing WHATWG (political or otherwise) ... @RByers, thoughts?

@RByers

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2016

I suggest we wait until UIEvents has been updated for this before trying to review a PR for PointerEvents (since we mostly just copy the patterns from UI Events here).

@hayatoito

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2016

@RByers

PR for UI events has been merged w3c/uievents#91.
Could you have a chance to review this PR for Pointer Events?

index.html Outdated
@@ -393,7 +394,7 @@
<h2>Firing events using the <code>PointerEvent</code> interface</h2>
<p>To <dfn>fire a pointer event name e</dfn> means to <dfn>fire an event named e</dfn> as defined in [[!DOM4]] with an event using the <a>PointerEvent</a> interface whose attributes are set as defined in <a href="#pointerevent-interface"><code>PointerEvent</code> Interface</a>.</p>

<p>Initialize the <code>bubbles</code> attribute for the event to <code>true</code> if the event name is</p>
<p>Initialize the <code>bubbles</code> attribute and the <code>composed</code> [[!WHATWG-DOM]] attribute for the event to <code>true</code> if the event name is</p>

This comment has been minimized.

Copy link
@RByers

RByers Jun 29, 2016

Contributor

The below list doesn't include pointerenter or pointerleave but you want those to be composed, right? I suggest moving the text for composed up to the above sentence so that it applies to all pointer events.

This comment has been minimized.

Copy link
@hayatoito

hayatoito Jun 30, 2016

Author Member

Good catch! Done.

@RByers

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2016

Oh, this is non-trivial enough that you should probably also add an entry to the revision history.

Fix #91. Make all pointer events composed events
All pointer events should propagate across Shadow DOM bounaries.
See w3c/webcomponents#513 for details.

@hayatoito hayatoito force-pushed the hayatoito:composed branch from 482e3d1 to 084907c Jun 30, 2016

@hayatoito

This comment has been minimized.

Copy link
Member Author

commented Jun 30, 2016

Oh, this is non-trivial enough that you should probably also add an entry to the revision history.

Thanks! I have added an entry to the revision history.

I have squashed the commits. Could you review PR again?

@patrickhlauke

This comment has been minimized.

Copy link
Member

commented Jun 30, 2016

LGTM

@patrickhlauke patrickhlauke merged commit be54665 into w3c:gh-pages Jun 30, 2016

@hayatoito hayatoito referenced this pull request Jun 30, 2016

Closed

Support Event.composed #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.