Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve intro figure #213

Merged
merged 3 commits into from Oct 28, 2021
Merged

Improve intro figure #213

merged 3 commits into from Oct 28, 2021

Conversation

pchampin
Copy link
Collaborator

@pchampin pchampin commented Oct 13, 2021

New text in the boxes, which hopefully makes their relationship more obvious.


Preview | Diff

@afs
Copy link
Collaborator

afs commented Oct 13, 2021

Nice.

If using text to create the linkages, then having the section two box at the top with five boxes below:

                           § 2. Concepts and Abstract Syntax
                                can be...

... queried with                      ... interpreted through         ... represented by
§ 4. SPARQL-star Query Language       § 6. RDF-star Semantics         § 7. RDF-star vocabulary

... updated with                       ... serialized with
§ 5. SPARQL-star Update                § 3. Concrete Syntaxes

@TallTed
Copy link
Member

TallTed commented Oct 13, 2021

It is very odd to have the boxes in the diagram numbered out of their presentation order there, particularly the §3 and §6 boxes.

I haven't considered it well, but it seems that the diagram should present those boxes in the same order as their numbers, so either

  • the boxes need renumbering and retitling to match the current doc section order, or
  • the sections need reordering to match the diagram, and the boxes then need renumbering to match

@pchampin
Copy link
Collaborator Author

@afs @TallTed here is a new layout which addresses both your concerns

@pchampin pchampin mentioned this pull request Oct 14, 2021
Copy link
Collaborator

@hartig hartig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this option (with the latest changes) better than #214

Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer this to #214.

@pchampin
Copy link
Collaborator Author

This was discussed during today's meeting: https://w3c.github.io/rdf-star/Minutes/2021-10-15.html#t04

@ericprud
Copy link
Member

I wonder if it's clearer to

s/... interpreted through
  § 6. RDF-star Semantics
 /... formally described with
  § 6. RDF-star Semantics
 /

You can't really query without interpreting the graph so my first inclination was to push the

... queried with
§ 4. SPARQL-star Query Language

to be on the far side of interpreted through, perhaps with lines indicating the dependency. But then I thought that most people probably felt they could write queries without grokking the semantics, which led to formally described with.

@pchampin
Copy link
Collaborator Author

@ericprud the original label was "reasoning", which is probably more to-the-point. Not sure why I changed it to "interpreted", which I agree is fuzzier. Would "... reasoned on with" work?

NB: I'll still merge this PR, but that does not prevent some further fine tuning...

@pchampin pchampin merged commit 1a47bd7 into main Oct 28, 2021
@gkellogg gkellogg deleted the improve-intro-figure branch November 13, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants