Fix warnings: promise is a basic type from WebIDl, no need to link. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is: - removing <a> around Promise. - Make Promise lowercase (promise). - Removing <a> around Resolve and Reject. - Rename Resolve to Fulfil.
|
avayvod@, PTAL. This is removing ~20 warnings. |
| @@ -404,7 +404,7 @@ | |||
| <a for="RemotePlabyackState">connecting</a>. | |||
| </li> | |||
| <li> | |||
| <a>Resolve</a> <var>promise</var> with <code>true</code>. | |||
| Fulfilled <var>promise</var> with <code>true</code>. | |||
There was a problem hiding this comment.
nit: I think in the algorithms we use infinitive form of the verb, so it should be Fulfill rather than Fulfilled here and in a few places below.
|
I merged the PR on my own with the correct form of the verbs. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
<a>around Promise.<a>around Resolve and Reject.