Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of default actions. #150

Merged
merged 2 commits into from May 16, 2018

Conversation

Projects
None yet
5 participants
@tdresser
Copy link
Contributor

tdresser commented Mar 19, 2018

As requested in issue #148.


Preview | Diff

@tdresser

This comment has been minimized.

Copy link
Contributor Author

tdresser commented Mar 20, 2018

@igrigorik - any idea why Travis is failing?

@igrigorik

This comment has been minimized.

Copy link
Member

igrigorik commented Mar 20, 2018

"Could not find .travis.yml, using standard configuration."

Paging @plehegar @siusin for help :-)

@siusin

This comment has been minimized.

Copy link
Contributor

siusin commented Mar 21, 2018

Travis is failing because there is no .travis.yml file in the branch. gh-pages is being used as v3, so we didn't set up any auto-pub script for it.

We can either ignore this warning, or start publishing v3 as working drafts under /TR, or commit the updates into the v2 branch since the group's intent was to focus on v2.

WDYT?

@igrigorik

This comment has been minimized.

Copy link
Member

igrigorik commented Mar 23, 2018

We decided earlier that we're not ready to do v3 work and should convert gh-pages back to v2.

@nicjansma I believe you had an AI for that?

@nicjansma

This comment has been minimized.

Copy link
Collaborator

nicjansma commented Apr 12, 2018

Yep, I'll make this change shortly

@tdresser

This comment has been minimized.

Copy link
Contributor Author

tdresser commented Apr 24, 2018

How do I get Travis to perform another test run?

@siusin

This comment has been minimized.

Copy link
Contributor

siusin commented Apr 24, 2018

@tdresser could you try do a pull from the upstream and push to your branch? Travis couldn't find the build script on your branch.

@tdresser

This comment has been minimized.

Copy link
Contributor Author

tdresser commented Apr 24, 2018

Of course, thanks.

@yoavweiss - can you review this?

@tdresser

This comment has been minimized.

Copy link
Contributor Author

tdresser commented May 8, 2018

@yoavweiss - ping!

@yoavweiss
Copy link
Contributor

yoavweiss left a comment

Apologies for the delay. LGTM

@yoavweiss yoavweiss merged commit 0b6e799 into gh-pages May 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ipr PR deemed acceptable.
Details

@yoavweiss yoavweiss deleted the tdresser-no-default-action branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.