Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore why eslint on Travis is too permissive #2074

Closed
saschanaz opened this issue Feb 5, 2019 · 3 comments
Closed

Explore why eslint on Travis is too permissive #2074

saschanaz opened this issue Feb 5, 2019 · 3 comments

Comments

@saschanaz
Copy link
Member

From #2073 (comment).

@saschanaz saschanaz changed the title Explorer why eslint on Travis is too permissive Explore why eslint on Travis is too permissive Feb 5, 2019
@saschanaz
Copy link
Member Author

I tried some back and forth on my own branch and found that eslint on Travis works correctly for src/core but not for src/core/linter-rules. Maybe some directory glob problem, but not sure why as we use same glob pattern on both Travis and local.

@marcoscaceres
Copy link
Member

Maybe OS level thing?

@saschanaz
Copy link
Member Author

@marcoscaceres Yes, it seems so... turns out that quoting helps. 🤦‍♀️

https://medium.com/@jakubsynowiec/you-should-always-quote-your-globs-in-npm-scripts-621887a2a784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants