Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force eslint #1777

Merged
merged 7 commits into from Jul 28, 2018
Merged

Force eslint #1777

merged 7 commits into from Jul 28, 2018

Conversation

saschanaz
Copy link
Member

This PR introduces npm run lint so that any Codacy errors can be prevented before opening a PR.

If you don't like some of the changes, now is the time to do a fine tune.

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but we need to make sure we are not going to cause too many conflicts in the incoming pull requests. Should mostly be fine tho, as running ESlint over those files should fix the same issues.

Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saschanaz saschanaz merged commit 273e51e into develop Jul 28, 2018
@saschanaz saschanaz deleted the force-eslint branch July 28, 2018 10:55
marcoscaceres added a commit that referenced this pull request Jul 31, 2018
* develop:
  v22.3.3
  refactor(core/jquery-enhanced): migrate $linkTargets to vanilla js (#1785)
  refactor: remove `var` (#1784)
  fix(core/idl): linking attribute id/type with same name (#1776)
  refactor(tests/spec/core/webidl-spec): remove remaining jQuery (#1783)
  refactor: lint tests (#1782)
  refactor: use const and arrow functions (#1781)
  refactor: use getElementById whenever possible (#1780)
  refactor: use await for makeRSDoc() (#1779)
  fix(karma.conf.js): grep causes incorrect skips (#1778)
  Force eslint (#1777)
  refactor(tests/spec/core/webidl-spec): remove jQuery from dict/enum tests (#1775)
  refactor(tests/spec/core/webidl-spec): remove jQuery from op/comment tests (#1774)
  refactor(tests/spec/core/webidl-spec): remove jQuery from ctor/const/attr tests (#1773)
  refactor(tests/spec/core/webidl-spec): remove jQuery from interface tests (#1772)
@saschanaz saschanaz mentioned this pull request Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants