feat(core/webidl): allow self-defining IDL #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Marcos Cáceres <marcos@marcosc.com>
|
Sometimes emojis are confusing... I'll consider it as a go sign 😆 |
|
sorry for the confusing emojis.... I've been reluctant on supporting this because I worry about Editors under-specifying things. In particular, not defining the steps to take when a method is called would not be great. Similarly with attributes, it makes it easy for developers to forget that "getting" an attribute may have side effects (not a good thing, but the reality is that implementation code runs... same with with setting... like setting an IDL attribute might be reflected in HMTL content). Anyway, let's see how we go with this... if things start getting messy, we can always make things more strict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more definition errors! Fixes #2316
<dfn>by default uses bold font, not sure we want it in IDL text.