Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assets/respec2): base.css removed underline from error links #2433

Merged
merged 2 commits into from Jul 20, 2019

Conversation

sidvishnoi
Copy link
Member

base.css was overriding broken links (a.respec-offending-element) and remove the squiggly underline.
Not sure if adding !important is good idea or not.

image
^^ squiggly underline not shown

@saschanaz
Copy link
Member

I wonder the text-decoration: none should be split into a separate rule a:not(.respec-offending-element) {} just because !important is generally not preferred... 🤔 My suggestion is still not very pretty though.

@sidvishnoi
Copy link
Member Author

What about:

- .respec-offending-element {
+ .respec-offending-element, a[href].respec-offending-element  {
  text-decoration: red wavy underline;
}

@saschanaz
Copy link
Member

saschanaz commented Jul 20, 2019

That seems good, with a comment about the reason.

Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sidvishnoi sidvishnoi merged commit c6bf864 into develop Jul 20, 2019
@sidvishnoi sidvishnoi deleted the offending-link branch July 20, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants