Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(w3c/headers): allow skipping latest published version in ED #2968

Merged
merged 4 commits into from Jun 17, 2020

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Jun 16, 2020

Fixes #1562

To skip adding a "Latest published version" link:

var respecConfig = {
  specStatus: "ED",
  latestVersion: null,
};

@marcoscaceres
Copy link
Member

marcoscaceres commented Jun 17, 2020

hmm... looking at this... maybe we should just allow conf.latestVersion to be set to null?

@sidvishnoi
Copy link
Member Author

sidvishnoi commented Jun 17, 2020

Agree with above. Though note that conf.latestVersion is our internal thing

@sidvishnoi sidvishnoi requested a review from marcoscaceres Jun 17, 2020
<dt>${l10n.latest_published_version}</dt>
<dd>
${conf.latestVersion
? html`<a href="${conf.latestVersion}"
>${conf.latestVersion}</a
>`
: "none"}
</dd>
${conf.latestVersion
? html`<dt>${l10n.latest_published_version}</dt>
<dd>
<a href="${conf.latestVersion}">${conf.latestVersion}</a>
</dd>`
: ""}
Copy link
Member Author

@sidvishnoi sidvishnoi Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the old behavior of showing "none" as latest version or skip it altogether like this PR does?

Copy link
Member

@marcoscaceres marcoscaceres Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good point! Yeah, “none” is good.

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Adding “none”, then this is perfect 🤗

@sidvishnoi sidvishnoi merged commit 2bcffb6 into develop Jun 17, 2020
2 checks passed
@sidvishnoi sidvishnoi deleted the skip-latest-published-version branch Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some way to drop "Latest published version" link for specs not published yet
2 participants