Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CHANGELOG): regenerate #3013

Merged
merged 1 commit into from Jul 11, 2020
Merged

chore(CHANGELOG): regenerate #3013

merged 1 commit into from Jul 11, 2020

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@sidvishnoi
Copy link
Member

O hai! 🎉
This PR was supposed to be sent on release, but it didn't. I did a manual run.
Not sure how to listen to "tag push" as we don't use release event.

@sidvishnoi
Copy link
Member

sidvishnoi commented Jul 10, 2020

As a note, this action will not trigger the lint/test PR checks (GitHub's default behavior unless we pass a personal access token).
So, we'll just merge it without tests. It's changelog - tests don't need to run anyway 😄

Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the previous PRs moving? 👀

@sidvishnoi
Copy link
Member

Don't know. github-changelog-generator does that everytime.
Maybe because of rate limits, sometimes issues/events fail to fetch, and changelog glitches.

@sidvishnoi
Copy link
Member

I like github-changelog-generator because it integrates PRs/issues well. We can alternatively use conventional-changelog - which is just git log with a filter.

Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I thought I approved this

@sidvishnoi sidvishnoi merged commit 9ea3388 into develop Jul 11, 2020
@sidvishnoi sidvishnoi deleted the regenerate-changelog branch July 11, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants