chore(.vscode/tasks.json): add npm start integration #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschanaz
approved these changes
Aug 16, 2020
| "script": "start", | ||
| "options": { | ||
| "env": { | ||
| "BROWSERS": "ChromeHeadless" |
There was a problem hiding this comment.
Can we do FirefoxHeadless, just because we love it 😁
I guess the change would require some format changes in problemMatcher so I'm still okay with this.
There was a problem hiding this comment.
I wanted to, but FirefoxHeadless didn't even start karma server for me. So, I decided to be lazy. Can you check if it works locally for you?
There was a problem hiding this comment.
It seems npm start -- --browsers Firefox is also broken 🤔
There was a problem hiding this comment.
FirefoxHeadless works fine in CI though 🤔
There was a problem hiding this comment.
Saving a file while in a npm start session starts Firefox for me. Kinda works
sidvishnoi
changed the title
marcoscaceres
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See demo: https://www.youtube.com/watch?v=xnUFQ9OiPrE
A good thing coming out of #3067
Not shown in video: the files in explorer (sidebar) get marked as failing also.