Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACTION-278: add change history for updates since 2nd PWD until 21st,March #633

Closed
wants to merge 1 commit into from

Conversation

danhlephuoc
Copy link
Contributor

I tracked down the closed PRs back to 5th, January, 2017, I was confused with PR #572 which contains several changes addressing several issues, I'm not sure I missed something.

Copy link
Collaborator

@dr-shorthair dr-shorthair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change any mention of owl:inverseOf into schema:inverseOf

I hadn't noticed this, but it makes sense. But presumably only applies to SOSA?

Add ObservableProperty and ActuablePropery

ActuatableProperty

Change sosa:madeByActuator to sosa:actuationMadeBy

Hmmm. This becomes inconsistent with comparable properties for observation and sampling.

@arminhaller
Copy link
Contributor

Please note that we have not changed the owl:inverseOf in SOSA to schema:inverseOf. There was no such decision made and SOSA still uses owl:inverseOf.

Copy link
Contributor

@maximelefrancois86 maximelefrancois86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Change any mention of owl:inverseOf into schema:inverseOf

As far as I can remember, the pull request I proposed that was named like this has been accepted, then reverted. SOSA still uses owl:inverseOf.

  1. Fix minor errors in sosa.ttl and ssn.ttl

Could that be a little more precise, or be deleted ?

  1. Address naming consitency with isObservedBy/observes,madeBySensor/madeObservation

little typo (consistency).

10.1 Add sosa:Actuation to domain/range of result properties

domain and range ? in sosa :-)

Rename invokes and invokedBy to madeActuation and madeByActuator

indeed, as Simon said, that's inconsistent with madeBySensor/madeObservation. As shown on figure https://www.w3.org/2015/spatial/wiki/File:20170308-foi-property-object-event.png

Add hasSimpleResult instead of hasValue

Should mention there is sosa:hasResult instead of ssn:hasValue, and sosa:hasSimpleResult instead of sosa:hasValue ?

Add ObservableProperty and ActuablePropery

ActuatableProperty ?

@arminhaller
Copy link
Contributor

@danhlephuoc could you please address the issues as above and recommit? Also, please try to use an editor that does not make line break changes so that it becomes clear that the only change that was made has been the change to the "change history".

@arminhaller
Copy link
Contributor

As of Maxime's comment, it should be schema:domainIncludes and schema:rangeIncludes.
We do have sosa:actuationMadeBy and sosa:madeActuation and sosa:madeBySensor and sosa:madeObservation in SOSA. This is not entirely consistent, but due to legacy. And we agreed to leave it like that.
It should be ActuatableProperty as maxime pointed out.

@arminhaller arminhaller closed this Apr 2, 2017
@maximelefrancois86 maximelefrancois86 deleted the danh-ssn-change-history branch December 13, 2017 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants