Displayable string language/dir support from document context #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…regarding inheritance of language and direction information from the document for use in the browser's native UX.
spec.bs
Outdated
| @@ -692,6 +692,8 @@ on the value of the [=current transaction automation mode=]: | |||
| :: Act as if the user has seen the transaction details and rejected | |||
| the authentication. | |||
|
|
|||
| NOTE: The language and direction of the {{CollectedClientAdditionalPaymentData/payeeName} and {{PaymentCredentialInstrument/displayName}} may often be determined from information inherited from the document. For discussion about enhanced support in JavaScript for language and direction of these displayable strings, see<a href="https://github.com/w3c/secure-payment-confirmation/issues/93">issue 93</a>. | |||
There was a problem hiding this comment.
Suggested change
| NOTE: The language and direction of the {{CollectedClientAdditionalPaymentData/payeeName} and {{PaymentCredentialInstrument/displayName}} may often be determined from information inherited from the document. For discussion about enhanced support in JavaScript for language and direction of these displayable strings, see<a href="https://github.com/w3c/secure-payment-confirmation/issues/93">issue 93</a>. | |
| NOTE: The language and direction of the {{CollectedClientAdditionalPaymentData/payeeName} and {{PaymentCredentialInstrument/displayName}} may be determined from information inherited from the document. For discussion about enhanced support in JavaScript for language and direction of these displayable strings, see<a href="https://github.com/w3c/secure-payment-confirmation/issues/93">issue 93</a>. |
(Remove often).
stephenmcgruer
approved these changes
Jun 23, 2022
|
Thanks, Stephen. I've folded in your suggestion. Let's wait to hear from I18N folks before merging. |
|
Closing this based on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Borrow language from the Payment Request API Proposed Recommendation regarding inheritance of language and direction information from the document for use in the browser's native UX.
Intended to address #93
Preview | Diff