-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [SecureContext] to derived interfaces #313
Comments
All changes to the derived interfaces have been landed. Thanks everyone who contributed and @foolip for bringing this issue to our attention. In addition to the IDL changes to the derived interfaces, I revisited the Generic Sensor API prose that talks about secure context and concluded no change are needed. Per WebIDL any derived interface must use We can now close this meta issue. |
That was quick, thanks! |
As it follows from w3c/sensors#313 Change-Id: Ic81e118b2a3c8db6d8b30ee61ef8811b88a0f970
Somewhat related: https://w3c.github.io/sensors/#construct-sensor-object says
Is that still necessary, given |
As it follows from w3c/sensors#313 Change-Id: Ic81e118b2a3c8db6d8b30ee61ef8811b88a0f970
As it follows from w3c/sensors#313 Change-Id: Ic81e118b2a3c8db6d8b30ee61ef8811b88a0f970 Reviewed-on: https://chromium-review.googlesource.com/721742 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#509707}
As it follows from w3c/sensors#313 Change-Id: Ic81e118b2a3c8db6d8b30ee61ef8811b88a0f970 Reviewed-on: https://chromium-review.googlesource.com/721742 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#509707}
As it follows from w3c/sensors#313 Change-Id: Ic81e118b2a3c8db6d8b30ee61ef8811b88a0f970 Reviewed-on: https://chromium-review.googlesource.com/721742 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#509707}
[This is a meta issue to track changes to the interfaces that inherit from
Sensor
.]All concrete sensors https://www.w3.org/2009/dap/#sensors that inherit from
Sensor
are only available within a secure context, since they implement https://w3c.github.io/sensors/#mitigation-strategies.However, the WebIDL spec states the following:
To fix this, the
[SecureContext]
extended attribute must be added to the following derived interfaces:AmbientLightSensor
ProximitySensor
Accelerometer
LinearAccelerationSensor
GravitySensor
Magnetometer
UncalibratedMagnetometer
Gyroscope
OrientationSensor
AbsoluteOrientationSensor
RelativeOrientationSensor
GeolocationSensor
The IDL guidance to concrete spec authors https://w3c.github.io/sensors/#example-webidl does include the
[SecureContext]
extended attribute already, so we're covered on that part. Perhaps worth looking that the prose in that section is aligned.Raised by @foolip in https://github.com/WICG/geolocation-sensor/issues/8
The text was updated successfully, but these errors were encountered: