Make SpeechSynthesisUtterance's voice attribute nullable #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@gshires @saschanaz care to review? This will still require tests, which in turn is blocked on #9. |
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 6, 2018
Collaborator
Author
|
Actually, this isn't blocked on #9, those tests didn't cover this anyway. Sent web-platform-tests/wpt#12319. |
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 6, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 8, 2018
…ce attribute is initially null, a=testonly Automatic update from web-platform-testsTest that SpeechSynthesisUtterance's voice attribute is initially null (#12319) Follows WebAudio/web-speech-api#22. -- wpt-commits: edb72456b7341d3dcc14323423a295261f67b25f wpt-pr: 12319
xeonchen
pushed a commit
to xeonchen/gecko-cinnabar
that referenced
this pull request
Aug 8, 2018
…ce attribute is initially null, a=testonly Automatic update from web-platform-testsTest that SpeechSynthesisUtterance's voice attribute is initially null (#12319) Follows WebAudio/web-speech-api#22. -- wpt-commits: edb72456b7341d3dcc14323423a295261f67b25f wpt-pr: 12319
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…ce attribute is initially null, a=testonly Automatic update from web-platform-testsTest that SpeechSynthesisUtterance's voice attribute is initially null (#12319) Follows WebAudio/web-speech-api#22. -- wpt-commits: edb72456b7341d3dcc14323423a295261f67b25f wpt-pr: 12319 UltraBlame original commit: f06d09389ca2612739dc1363327ec1736e6241b2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…ce attribute is initially null, a=testonly Automatic update from web-platform-testsTest that SpeechSynthesisUtterance's voice attribute is initially null (#12319) Follows WebAudio/web-speech-api#22. -- wpt-commits: edb72456b7341d3dcc14323423a295261f67b25f wpt-pr: 12319 UltraBlame original commit: f06d09389ca2612739dc1363327ec1736e6241b2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…ce attribute is initially null, a=testonly Automatic update from web-platform-testsTest that SpeechSynthesisUtterance's voice attribute is initially null (#12319) Follows WebAudio/web-speech-api#22. -- wpt-commits: edb72456b7341d3dcc14323423a295261f67b25f wpt-pr: 12319 UltraBlame original commit: f06d09389ca2612739dc1363327ec1736e6241b2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: web-platform-tests/wpt#12319
Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=30010.
Preview | Diff