Accessibility Update - #89
Merged
Merged
Conversation
Contributor
|
I think @jenstrickland was also recommending aria-label for these. I think that native ARIA semantics of HTML are sufficient. Jen, if you think we are missing anything from an a11y perspective, please open an issue. |
TzviyaSiegman
self-requested a review
July 18, 2025 12:50
TzviyaSiegman
approved these changes
Jul 18, 2025
|
The only reason to add |
Member
Author
|
I've issued another PR with a resolution that is known to resolve the Safari quirk. |
Member
|
Nice work everyone 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves @jenstrickland issue with the SC cross-link's.
They are now structurally separated into UL's for accessibility purposes.
Preview | Diff