Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'autofocus' core attribute #728

Merged
merged 3 commits into from Aug 31, 2019
Merged

Conversation

@tkent-google
Copy link
Contributor

@tkent-google tkent-google commented Aug 27, 2019

This fixes #726

Copy link
Contributor

@AmeliaBR AmeliaBR left a comment

I haven't run a test build yet, but looks good. Thanks Kent!

Final tests & merge should be run when the HTML PR is merged: whatwg/html#4830

</tr>
<tr>
<td><dfn id="SVGElementAutofocusAttribute" data-dfn-for="core-attributes" data-dfn-type="element-attr">autofocus</dfn></td>
<td><a href="https://html.spec.whatwg.org/C/#boolean-attribute">boolean attribute</a> <span class="syntax">[HTML]</span></td>
Copy link
Contributor

@AmeliaBR AmeliaBR Aug 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be the first pure boolean attribute we've adopted from HTML. (crossorigin can be used in a boolean manner, but it also has allowed values).

I think linking to this definition should be sufficient, but pointing this out in case anyone disagrees.

master/struct.html Show resolved Hide resolved
Co-Authored-By: Amelia Bellamy-Royds <amelia.bellamy.royds@gmail.com>
@domenic
Copy link

@domenic domenic commented Aug 30, 2019

HTML spec PR merged!

@AmeliaBR AmeliaBR merged commit d9d28ad into w3c:master Aug 31, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants