Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two value percentage fontSize not fully defined. #215

Closed
nigelmegitt opened this issue Oct 14, 2016 · 5 comments · Fixed by #301
Closed

Two value percentage fontSize not fully defined. #215

nigelmegitt opened this issue Oct 14, 2016 · 5 comments · Fixed by #301
Assignees
@palemieux
Labels
bug discussed and agreed pr open
Milestone
3rd Ed CR

Comments

@nigelmegitt
Copy link
Contributor

See w3c/ttml2#200
@skynavga
Copy link
Contributor

Premise is false. Closing.

@nigelmegitt nigelmegitt reopened this Oct 14, 2016
@nigelmegitt
Copy link
Contributor Author

Premise still under discussion. Reopening.

@skynavga skynavga changed the title Two value percentage fontSize not fully defined Two value percentage fontSize not fully defined. Dec 22, 2016
@nigelmegitt nigelmegitt added this to the TTML1 Third Edition milestone Jan 12, 2017
@nigelmegitt
Copy link
Contributor Author

[Meeting 2017-01-12] Implement as per w3c/ttml2#200.

@palemieux
Copy link
Contributor

@nigelmegitt Please confirm that https://github.com/w3c/ttml2/pull/336/files meets your expectations since you have a number of outstanding comments on the PR.

@nigelmegitt
Copy link
Contributor Author

@palemieux Yes, we discussed this at length in a meeting whose minutes I can't locate by searching - I recall @skynavga working through an example that took ~100% of my available brain capacity to process (and therefore I wasn't able to scribe it adequately) but resulted in me being convinced that there was no problem with that pull request.

@palemieux palemieux assigned palemieux and unassigned skynavga Dec 16, 2017
palemieux added a commit that referenced this issue Dec 19, 2017
@palemieux
Clarify tts:fontSize specified in 'em' units (#214)
1b12f1f 
Clarify tts:fontSize specified using two percentage values (#215)
@palemieux palemieux mentioned this issue Dec 19, 2017
Merged
palemieux added a commit that referenced this issue Feb 22, 2018
@palemieux
Clarify tts:fontSize semantics (#206, #214 and #215)
c01c095
@palemieux palemieux mentioned this issue Aug 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palemieux palemieux

Labels
bug discussed and agreed pr open
Projects
None yet
Milestone
3rd Ed CR
Development

Successfully merging a pull request may close this issue.

Clarify tts:fontSize semantics w3c/ttml1
3 participants
@skynavga @palemieux @nigelmegitt