Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adjacent background area merging #189

Closed
nigelmegitt opened this issue Sep 22, 2016 · 5 comments

Comments

@nigelmegitt
Copy link
Contributor

commented Sep 22, 2016

Follow-on from #176 which was closed since the core issue, corner rounding, was resolved. This is the new home for the additional requirement to merge background areas such that the corner rounding results in a nice looking output.

Extracted comments from: #176 (comment) and #176 (comment)

None of the examples of rounded borders I have seen use different radii for the two directions, so I'd advocate simplifying to a single value for now, until a need for two radii is presented.

However one thing that may be underspecified at the moment is the flow of rounded rectangles between adjacent areas. I've seen this kind of thing:
image

where I would rather have seen something like this:
image

or even perhaps:

image

In other words when creating a composite background shape from congruent area backgrounds the radial centre should be offset in the direction of the hypotenuse of the right angle triangle formed between the vertex being drawn and the two adjacent vertices, not away from it. There are probably more elegant ways to describe this!

Further examples from f2f meeting 2016-09-19:

image

and

image

These require a little more thought in terms of how to specify them

@skynavga skynavga modified the milestone: TTML2WR Feb 23, 2017
@nigelmegitt

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2017

Meeting 2017-05-11: Agreed to add examples for backgrounds on p and span with rounded borders, assigned to Nigel.

@skynavga

This comment has been minimized.

Copy link
Collaborator

commented May 11, 2017

Note that example images for span and p should be the first and last images in the first comment above.

@skynavga

This comment has been minimized.

Copy link
Collaborator

commented May 16, 2017

@nigelmegitt what is your schedule for a PR to add examples?

@skynavga

This comment has been minimized.

Copy link
Collaborator

commented May 29, 2017

Lacking a PR, I am taking this off my work list. If a PR is posted, then please restore to my list.

@skynavga skynavga removed this from the Editor's WR Work List milestone May 29, 2017
nigelmegitt added a commit that referenced this issue May 31, 2017
One image for the existing example, the other with an XML example for
rounded borders as per #189.
@nigelmegitt nigelmegitt added this to the Editor's WR Work List milestone May 31, 2017
@nigelmegitt nigelmegitt added the pr open label May 31, 2017
@nigelmegitt

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2017

I've opened a PR, and put it back on your list @skynavga .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.