Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify use of tts:textCombine (#278). #619

Merged
merged 7 commits into from Feb 16, 2018

Conversation

@cconcolato
Copy link
Contributor

cconcolato commented Jan 31, 2018

closes #278

@cconcolato cconcolato self-assigned this Jan 31, 2018
@cconcolato cconcolato requested review from skynavga and r12a Jan 31, 2018
determines whether and how multiple nominally non-combining characters are combined so that their <loc href="#terms-glyph-area">glyph areas</loc>
consume the nominal bounding box of a single em square of the surrounding vertical text.
determines whether and how multiple characters, such as digits, are combined so that their
<loc href="#terms-glyph-area">glyph areas</loc> consume a smaller bounding box, potentially the nominal bounding box of a single em square of the surrounding vertical text.

This comment has been minimized.

Copy link
@cconcolato

cconcolato Jan 31, 2018

Author Contributor

In fact, looking at the matching CSS property. That property also says "the combination of multiple characters into the space of a single character". I was confused by the example rendering below where 4 characters (AB34) are not collapsed to fit in one em box. I will revert that text and update the example.

@cconcolato cconcolato added the agenda label Feb 1, 2018
@cconcolato cconcolato removed the agenda label Feb 8, 2018
cconcolato added 4 commits Feb 12, 2018
@cconcolato cconcolato added the agenda label Feb 15, 2018
@r12a
r12a approved these changes Feb 15, 2018
Copy link
Collaborator

skynavga left a comment

May have other comments during CR, but ok for now.

@skynavga skynavga removed the agenda label Feb 15, 2018
@skynavga skynavga changed the title clarify use of tts:textCombine Clarify use of tts:textCombine (#278). Feb 15, 2018
@skynavga skynavga added the editorial label Feb 16, 2018
@cconcolato cconcolato merged commit 5f09655 into master Feb 16, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
ipr PR deemed acceptable.
Details
@skynavga skynavga deleted the issue-0278-textCombine-clarifications branch Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.