Clarify that text emphasis applies to glyph areas using language from… #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tts:textDecoration (#781).
palemieux
approved these changes
May 27, 2018
nigelmegitt
reviewed
May 30, 2018
There was a problem hiding this comment.
I reviewed this post-merge, and see that it at least partially resolves the issue. I'm not going to argue with @palemieux 's review since he opened the issue, but it occurs to me that "other inline areas that are generated by content flowed into a region" is perhaps open to misinterpretation - does it suggest that a nested span might generate an inline area that gets a single text emphasis mark? Is that desirable? I'm not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… tts:textDecoration (#781).
Closes #781.