Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note potential for false negatives with [validate document] (#876). #886

Merged
merged 5 commits into from
Jul 23, 2018

Conversation

skynavga
Copy link
Collaborator

Closes #876.

@skynavga skynavga added this to the PR milestone Jul 12, 2018
@skynavga skynavga self-assigned this Jul 12, 2018
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very abstract, and that makes me doubt its helpfulness. A concrete mechanism for why the validation errors might not be noticed would make this much more helpful. For example the fact that the provided informative schemas treat some datatypes e.g. time expressions as generic text strings could result in false positives when a non-conformant string is present.

spec/ttml2.xml Outdated
<loc href="#semantics-validation-state-validation-exception">validation exception</loc>, in which case,
the results of <loc href="#terms-validation-processing">validation processing</loc> may be considered a <emph>false positive</emph>.</p>
<p>As an example, a <loc href="#terms-content-profile">content profile</loc> may prohibit the use of a feature by means of the
<code>prohibted</code> value of the <code>value</code> attribute of a <loc href="#profile-vocabulary-feature"><el>ttp:feature</el></loc>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: s/prohibted/prohibited

@skynavga skynavga modified the milestones: PR, CR3 Jul 19, 2018
@skynavga
Copy link
Collaborator Author

@nigelmegitt addressed comments, please re-review

every possible <termref def="defs-validation-error">validation error</termref>, then performing the
<loc href="#semantics-procedure-validate-document">[validate document]</loc> procedure need not produce a
<loc href="#semantics-validation-state-validation-exception">validation exception</loc>, in which case,
the results of <loc href="#terms-validation-processing">validation processing</loc> may be considered a <emph>false positive</emph>.</p>
Copy link
Contributor

@nigelmegitt nigelmegitt Jul 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, using the current TTML schemas typically generates false negatives when using semicolon-delimited lists of values in style attributes in an animation context, except where the schema just defines the syntax to be a string.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. Perhaps I will swap it for the current discussion that uses an RNC example.

@skynavga
Copy link
Collaborator Author

Merged early per WG resolution to move forward with CR3 CfC.

@skynavga skynavga deleted the issue-0876-validate-document branch October 4, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants