Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare keypress event should be fired when pressing Enter, Shift + Enter and Ctrl + Enter #183

Open
masayuki-nakano opened this issue Feb 18, 2018 · 2 comments

Comments

@masayuki-nakano
Copy link

@masayuki-nakano masayuki-nakano commented Feb 18, 2018

Currently, keypress event is declared as:

If supported by a user agent, this event MUST be dispatched when a key is pressed down, if and only if that key normally produces a character value.

However, in any browsers, Enter, Shift + Enter, Ctrl + Enter causes keypress event in any desktop OSes.

Unfortunately, whether keypress event is fired for Alt + Enter and Meta + Enter, and also 2 or modifiers + Enter depends on browser and platform...

@masayuki-nakano
Copy link
Author

@masayuki-nakano masayuki-nakano commented Dec 18, 2018

  • Firefox (65~): Enter, Shift+Enter, Ctrl+Enter
  • Edge: Enter, Shift+Enter, Ctrl+Enter
  • Chrome on Windows: Enter, Shift+Enter, Ctrl+Enter
  • Chromium on Linux: Enter, Shift+Enter, Ctrl+Enter, Shift+Ctrl+Enter, Super+Enter, Super+Shift+Enter, Super+Ctrl+Enter, Super+Shift+Ctrl+Enter
  • Chrome on macOS: Enter, Shift+Enter, Ctrl+Enter, Shift+Ctrl+Enter, Alt+Enter, Shift+Alt+Enter, Alt+Ctrl+Enter, Shift+Alt+Ctrl+Enter
  • Safari: Enter, Shift+Enter, Ctrl+Enter, Shift+Ctrl+Enter, Alt+Enter, Shift+Alt+Enter, Alt+Ctrl+Enter, Command+Enter, Shift+Command+Enter, Ctrl+Command+Enter, Alt+Command+Enter, Shift+Ctrl+Command+Enter, Shift+Alt+Command+Enter, Shift+Alt+Ctrl+Command+Enter
@masayuki-nakano
Copy link
Author

@masayuki-nakano masayuki-nakano commented Dec 18, 2018

@garykac Could you take a look this issue? This inconsistency could cause making incompatible web apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants