Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that non-objects aren't allowed as VC graphs. #1390

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Conversation

msporny
Copy link
Member

@msporny msporny commented Dec 17, 2023

This PR attempts to address issue #1365 by clarifying that non-object values are not allowed for Verifiable Credential Graphs.


Preview | Diff

@msporny msporny changed the title Clarify that non-objects aren't allowed in VC graphs. Clarify that non-objects aren't allowed as VC graphs. Dec 17, 2023
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming my suggestions will be applied. Thanks!

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
index.html Outdated Show resolved Hide resolved
Copy link
Member

@brentzundel brentzundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with Ted's suggestion

@iherman
Copy link
Member

iherman commented Dec 20, 2023

The issue was discussed in a meeting on 2023-12-19

  • no resolutions were taken
View the transcript

2.7. Clarify that non-objects aren't allowed as VC graphs. (pr vc-data-model#1390)

See github pull request vc-data-model#1390.

Brent Zundel: "Clarify that non-objects aren't allowed as VC graphs". This has a broad set of approvers, one request for changes.
… From Ted who is bringing editorial clarity with his suggestion. I expect this to be merged without trouble by the end of the week.
… Happy for comments if there are any.
… No one on the queue here either.

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@msporny
Copy link
Member Author

msporny commented Dec 26, 2023

Normative, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 221ed5e into main Dec 26, 2023
1 check passed
@msporny msporny deleted the msporny-vcg-values branch December 26, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants