Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate descriptive language #183

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

selfissued
Copy link
Collaborator

@selfissued selfissued commented Nov 25, 2023

This removes duplicate language in the description of the use of JOSE header parameters and JWT claims. In the process, I moved the "JOSE Header Parameters" section before the "Key Discovery" section.

I added missing COSE content that corresponds to existing JOSE content.

I moved the "Wallets" section nearer to the end.

I believe that this is the last thing that we must do before submitting for CR.

Fixes #135


Preview | Diff

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted many other places, just as there is no such thing as application/jpg+zip, the application/vp+ld+json+sd-jwt media type should not exist; this media type should be simply application/sd-jwt. The described reasoning behind wanting media types like application/vp+ld+json+sd-jwt would be well satisfied and better conform to RFC history by specifying profiles for the application/sd-jwt media type.

index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@selfissued
Copy link
Collaborator Author

@TallTed wrote:

the application/vp+ld+json+sd-jwt media type should not exist; this media type should be simply application/sd-jwt.

This PR does not change the media types in the specification, nor is it the right place to do so. Therefore, @TallTed, I'd ask you to withdraw your suggestions to change the media types here, since that's not the topic of the PR. If you want to discuss media types, I believe that issue #179 is already the right place to do so. Thanks.

@@ -700,7 +751,7 @@ <h2>Verification Methods</h2>
<h3>Verification Material</h3>

<p>
Verification material SHOULD be expressed in the <code>publicKeyJwk</code> property
Verification material MUST be expressed in the <code>publicKeyJwk</code> property
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. Does this prevent DIDs that do not use publicKeyJwK from creating vc-jose-cose objects?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd turn the statement around. It makes it clear that DIDs used with vc-jose-cose need to support the JWK key representation. This increases interoperability.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the SHOULD, since I don't plan to be working with JSON in the future, whenever possible.

Copy link
Collaborator

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks great - few small comments

See <a href="https://www.ietf.org/archive/id/draft-ietf-cose-typ-header-parameter-00.html/">I-D.ietf-cose-typ-header-parameter</a>
<p>
[[RFC9052]] MAY be used to secure this media type.
The <code>typ</code> header parameter SHOULD be <code>application/vc+ld+json+cose</code>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of consistency this will also need to update, depending on #184

Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, these changes seem excellent.

I don't think there is any normative changes here, except for the SHOULD to MUST regarding key representations...

I note that this would prevent future implementers from using a COSE Key to verify a SD-JWT.. perhaps that is acceptable.

@OR13
Copy link
Contributor

OR13 commented Nov 27, 2023

@TallTed I filed, #184

to track your request to adjust the registration requests associated with typ.

lets get the argument for why you think that change should be made clearly captured there, and we will need to address it pre CR, I am going to resolve those suggestions for now.

@OR13
Copy link
Contributor

OR13 commented Nov 27, 2023

@TallTed I sent some emails to the relevant lists regarding your proposal, lets continue the media type parameter discussion on #184.

Can you review again (assuming we will address 184 separately before CR) ?

Edit: I changed my mind, I think we need to address @TallTed 's comments in this PR, or at least have a path forward regarding profile and application/vc+... see w3c/vc-data-model#1363

Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get clarity on the profile issue related to the core data model, before we merge this... see:

w3c/vc-data-model#1363 (comment)

@OR13 OR13 self-requested a review November 27, 2023 18:50
@OR13
Copy link
Contributor

OR13 commented Nov 27, 2023

After editors call, I agreed to address @TallTed 's feedback on typ in a separate PR, which is now up here: #186

There will be merge conflicts, if this PR is merged, but I can address them, and #186 makes it clear one way to resolve this issue.

@OR13
Copy link
Contributor

OR13 commented Dec 1, 2023

Open for a week, no objections, merging.

@OR13 OR13 merged commit 7552752 into w3c:main Dec 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can registered JWT claims be used only in the JOSE header??
4 participants