Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menus for Responsive Design #530

Closed
wants to merge 1 commit into from
Closed

Menus for Responsive Design #530

wants to merge 1 commit into from

Conversation

brewerj
Copy link

@brewerj brewerj commented Jun 23, 2017

Proposed new subhead "Responsive design" to improve coverage of mobile menus.

Is there a better location to place this? Also, does this need a code snippet, or snippets?

Additionally, this resource could be added to the "further resources" section:

Proposed new subhead "Responsive design" to improve coverage of mobile menus. 

Is there a better location to place this? Also, does this need a code snippet, or snippets? 

Additionally, this resource could be added to the "further resources" section: 
- From "Understanding WCAG 2.0": <https://www.w3.org/TR/UNDERSTANDING-WCAG20/consistent-behavior-consistent-locations.html>
@brewerj brewerj self-assigned this Jun 23, 2017
@yatil yatil changed the title Update structure.html.erb.md Menus for Responsive Design Jun 23, 2017
Copy link
Contributor

@iamjolly iamjolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good information, worth saying in this spot. I'm not sure that it needs a code snippet(s) to convey the message well.

Should we add "and with the same wording and meaning" to:

...but items that show should appear in the same order and with the same wording and meaning.

?

@yatil
Copy link
Contributor

yatil commented Jun 28, 2017

@iamjolly Maybe instead of “and with the same wording and meaning” we could write “and with the same wording and destination”? (I think that is what you think of as “meaning”, but if the context is the same, the wording has the same meaning. Or doesn’t it?!)

@yatil yatil added the mobile label Jun 28, 2017
@iamjolly
Copy link
Contributor

Yes. I like your further edit @yatil.

...but items that show should appear in the same order and with the same wording and destination.

@bakkenb
Copy link
Contributor

bakkenb commented Jun 28, 2017

+1 to @iamjolly edit.

Also do not think code snippet is needed, unless this is something that is difficult to code and could us some reference examples.

@notabene
Copy link
Member

+1 to all.

@nrhsinclair
Copy link

nrhsinclair commented Jul 5, 2017

How about:
Menu structure should be consistent across screen sizes. Some menu items may be collapsed or even hidden in sub navigation menus, but items that show should maintain consistent order, purpose, and labels across all screen sizes.

...Menus should be accessible by touch and keyboard.

@hkramer
Copy link
Contributor

hkramer commented Jul 6, 2017

I worry about nrhsinclair's use of labels. Not clear if this is visible labels or semantic (non-visible) label. Otherwise I like the wording. Perhaps replace labels in that version with "wording."

@yatil
Copy link
Contributor

yatil commented Sep 9, 2019

Thanks for the input. I’ll create a new draft when I have put the tutorial into the new layout :-)

@brianelton
Copy link
Collaborator

Based on above feedback, the new text should read:
"Menu structure should be consistent across screen sizes. Some menu items may be collapsed or even hidden in sub navigation menus, but items that show should appear in the same order and with the same wording and destination. Menus should be accessible by touch and keyboard."
Will open a new PR with the most recent file (new layout)

Copy link

@lakeen lakeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to latest text

@brianelton
Copy link
Collaborator

Updates covered in #721. Closing PR.

@brianelton brianelton closed this May 9, 2023
@brianelton brianelton deleted the brewerj-patch-5 branch May 9, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants