Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit mention of SPAs and dynamic changes of title to 2.4.2 understanding #2107

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

patrickhlauke
Copy link
Member

  • this marries up nicely with the existing example already present talking about a web application for banking
  • minor additional tweak: change his to their in the wording for the banking example

Closes #2102

* this marries up nicely with the existing example already present talking about a web application for banking
* minor additional tweak: change `his` to `their` in the wording for the banking example

Closes #2102
@mraccess77
Copy link

Thanks! @patrickhlauke not sure if we need another word rather than "should" - sometimes I use "needs to" - but some people are more sensitive to this.

Also, not related to your commit -but I think we should pull the account number from being displayed in the page title. Perhaps we might say "saving account" or "account ending in xxxx" .
page titles seems like a way that PII could be leaked. Thoughts? ttps://support.google.com/analytics/answer/6366371?hl=en#zippy=%2Cin-this-article

@patrickhlauke
Copy link
Member Author

@mraccess77 good point about security on that separate example. rolled a tweak into this PR for it as well

as for the use of "should", I think this is appropriate in this case because it clarifies that there may still be valid reasons for NOT changing the title, as this SC still does have that element of human judgement about it when deciding what is and isn't an appropriately descriptive title. don't think it would be confused with a normative uppercase SHOULD

@patrickhlauke
Copy link
Member Author

Any news on this @alastc ?

@LaurenceRLewis
Copy link
Contributor

I don't see the changes in relation to SPA in the Understanding document as described in the pull request 'Add explicit mention of SPAs and dynamic changes of title to 2.4.2 understanding #2107'

"In cases such as Single Page Applications (SPAs), where various distinct pages/views are all nominally served from the same URI and the content of the page is changed dynamically, the title of the page should also be changed dynamically to reflect the content/topic of the current view."

Was this every implemented?

@patrickhlauke
Copy link
Member Author

I don't see the changes [...] Was this every implemented?

@LaurenceRLewis as this pull request is still open, and not merged, i think there's your answer

@hidde
Copy link
Member

hidde commented Jun 29, 2023

Just stumbled upon this PR and would very much support it to be merged in, very useful addition.

@marie450
Copy link

This PR would resolved a lot of discussion between our redaction and accessibility teams as all of our traditional HTML documents are replace by SPA.

@bruce-usab bruce-usab self-assigned this Dec 8, 2023
made the user plural so that the non-gender specific pronoun "their" can be used grammatically
Adopted a non-gender specific name as well.
@mbgower mbgower merged commit 2fb72ae into main Jan 12, 2024
1 check passed
@patrickhlauke patrickhlauke deleted the patrickhlauke-issue2102 branch January 12, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify in understanding SC 2.4.2 Page Title applicability to single page applications
8 participants