-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit mention of SPAs and dynamic changes of title to 2.4.2 understanding #2107
Conversation
* this marries up nicely with the existing example already present talking about a web application for banking * minor additional tweak: change `his` to `their` in the wording for the banking example Closes #2102
Thanks! @patrickhlauke not sure if we need another word rather than "should" - sometimes I use "needs to" - but some people are more sensitive to this. Also, not related to your commit -but I think we should pull the account number from being displayed in the page title. Perhaps we might say "saving account" or "account ending in xxxx" . |
@mraccess77 good point about security on that separate example. rolled a tweak into this PR for it as well as for the use of "should", I think this is appropriate in this case because it clarifies that there may still be valid reasons for NOT changing the title, as this SC still does have that element of human judgement about it when deciding what is and isn't an appropriately descriptive title. don't think it would be confused with a normative uppercase SHOULD |
Any news on this @alastc ? |
I don't see the changes in relation to SPA in the Understanding document as described in the pull request 'Add explicit mention of SPAs and dynamic changes of title to 2.4.2 understanding #2107' "In cases such as Single Page Applications (SPAs), where various distinct pages/views are all nominally served from the same URI and the content of the page is changed dynamically, the title of the page should also be changed dynamically to reflect the content/topic of the current view." Was this every implemented? |
@LaurenceRLewis as this pull request is still open, and not merged, i think there's your answer |
Just stumbled upon this PR and would very much support it to be merged in, very useful addition. |
This PR would resolved a lot of discussion between our redaction and accessibility teams as all of our traditional HTML documents are replace by SPA. |
made the user plural so that the non-gender specific pronoun "their" can be used grammatically
Adopted a non-gender specific name as well.
his
totheir
in the wording for the banking exampleCloses #2102