Repository navigation
Update 2.5.8 Target Size (Minimum) understanding for new spacing approach - #3103
Conversation
…oach Companion for #3089 * remove outdated target offset language and examples * reinforce the fact that this requires *either* minimum size *or* spacing in prose * add new spacing diagram as SVG, with link to scalable version directly * change the `<ol>` in the "Exceptions" section to `<ul>` - it's unordered in the normative SC wording, so why make it a numbered list here? * markup cleanup * delete unused images
|
Set to draft for now, as I want to work on an additional SVG to illustrate the "circle must not overlap an adjacent target itself" aspect (using one target that's below 24x24, next to a target that's above 24x24 - i.e. where there's no circle to consider for the latter) |
detlevhfischer
left a comment
There was a problem hiding this comment.
Looks good to me.
Spacing exception: "..any other other adjacent targets, nor the adjacent targets themselves" is more explicit, better.
Great graphics!
|
suggestion from @graemecoleman to split the one large diagram for the spacing exception into three separate diagrams. makes sense, at it will be much more readable and avoid the giant front-loaded explanation. will work on this if agreed in principle here that this is the approach we want to take |
|
@detlevhfischer hah, spotted a typo (duplicate "other") thanks to your comment too :) |
|
thoughts on my additional diagram I wanted to make to show the "overlaps the adjacent target" aspect? this also covers the same ground as the old boy/girl/magnifying glass image (this is only a rough at this stage, can tweak it to be pixel-perfect and write some prose for it if this is deemed ok) /cc @detlevhfischer looking at this now, this could actually benefit from being split into at least two separate ones ... the small magnifying glass next to the large image, and then the special case of it being on top of the image |
|
@patrickhlauke I have a view suggestions:
Numbering your current images from the top left to bottom right in normal reading order, you'd have this structure: |
there's two columns on that image. on the left side, the targets and their measurements. on the right side, the same one but with the circle overlaid. this is to make sure that you can actually see the actual thing on the left properly, not covered by the circle already that obfuscates things. and the first row, as it's >= 24x24, doesn't need a circle to begin with |
|
sorry I didn't get that logic just from the illustration, at least it is not easy to understand - I saw these as separate cases. I only now see they are actually the same! I would simplify and draw the circle whenever the target is below 24 x 24... and this will reduce the examples needed. |
|
or have something like a magnifed cutoff section in a bubble which shows the superimposed circle, so it is clear this is the same case... |
|
hmm, i might keep it but fiddle with it some more to make it clearer. it's the same approach i took on the other illustration https://github.com/w3c/wcag/pull/3103/files#diff-786f623a8b64dae0e1e505269cd93844a7a122de868e1db6665d28e601baaa4b probably can do with splitting this into two images though (the overlapping case, and the abutting case), and having a horizontal ruler thing like in that other illustration to make it clear it's one row |
|
Well yeah there are a thousand ways to do this - it all seems pretty clear to me when I look at it now, but I got the wrong idea at first. |
|
i'll noodle around some more with it in any case. btw, as i've lost track...how likely does it seem that we'll be adopting the simpler circles model versus the target offset weirdness? |
@patrickhlauke I suspect the odds are very high now that a new CR is in order, and that it will be discussed in a couple of minutes on the backlog call, if you can attend |
|
@mbgower unfortunately friday afternoons are the worst time in the week for me to attend live (otherwise i'd have loved to be more active in the backlog stuff directly myself, rather than just sniping from the sides here on github) |
01e0c6f to
210f7ed
Compare
|
just added a slightly cleaned-up version of my proposed "overlapping and touching/abutting targets" diagram, with prose - see the updated https://raw.githack.com/w3c/wcag/patrickhlauke-target-size-minimum-issue3089-companion/understanding/22/target-size-minimum.html (at the end of the "Spacing" section) |
|
@patrickhlauke Yes, the dividing line have done it. Good stuff. Now let's hope the circle exception will make it into 2.2. |
…large second svg into two
|
Need to see how #3097 will affect this too |
e082b8a to
478c65f
Compare
detlevhfischer
left a comment
There was a problem hiding this comment.
Great stuff - thanks for improving the examples!
|
thanks @detlevhfischer ... slowly getting there :) |
|
@detlevhfischer @mbgower added a whole bit at the start of the "Spacing" section now to explain the concept of the 24 CSS diameter circle and how to center it (for square/rectangular, convex, and concave targets) ... I think, from my point of view, this was the last piece of the puzzle. happy to wordsmith further (as the explanation there was admittedly a bit rushed), but otherwise will make this PR ready for review when/if the actual SC wording changes to use the spacing approach |
ead2889 to
01c7f67
Compare
01c7f67 to
acb1448
Compare
Removed "at least" in a fairly long sentence where it did not seem to be necessary and was disrupting the readability.
|
Great work, @patrickhlauke ! A vast improvement, and the whole thing reads very well. |
|
@patrickhlauke It's really come a long way. Beautiful work. Good to see also graphics for irregular shapes. I am not sure if @dbjorge's proposal to swap "be able to draw a 24x24 rectangle inside the target" for a 24 x 24 circle is still a option but it looks like the impact on this understanding text would be minimal (one small change in section "Size requirement"). |
While I was thinking about that as well while revising this, that would essentially change the whole nature of the SC (as then we're not talking about "The size of the target for pointer inputs is at least 24 by 24 CSS pixels" since the size is understood as "a width of 24 CSS pixels and a height of 24 CSS pixels", and that thing with the rectangle/square helps in determining that part |
78d1253 to
d7729d2
Compare
Addresses #3045 more directly
d7729d2 to
e21377c
Compare

Companion for
#3089#3123<ol>in the "Exceptions" section to<ul>- it's unordered in the normative SC wording, so why make it a numbered list here?Supersedes #3058 if #3089 gets accepted and merged
Closes #2755
Closes #3045
RawGit preview: https://raw.githack.com/w3c/wcag/patrickhlauke-target-size-minimum-issue3089-companion/understanding/22/target-size-minimum.html