Support partial dictionaries #10159
Merged
Support partial dictionaries #10159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build PASSEDStarted: 2018-03-28 20:48:23 View more information about this build on: |
lukebjerring
commented
Mar 23, 2018
| idlArray.test(); | ||
| } catch (e) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
try/catch code-smell covered by #10162
lukebjerring
force-pushed
the
idlharness-partial-dictionary
branch
from
7b89105
to
a33361b
Compare
foolip
approved these changes
Mar 28, 2018
resources/idlharness.js
Outdated
| @@ -257,7 +257,8 @@ IdlArray.prototype.internal_add_idls = function(parsed_idls, options) | |||
|
|
|||
| parsed_idls.forEach(function(parsed_idl) | |||
| { | |||
| if (parsed_idl.type == "interface" && parsed_idl.partial) | |||
| if (parsed_idl.partial | |||
| && ["interface", "dictionary"].find(t => parsed_idl.type == t)) | |||
There was a problem hiding this comment.
Optional simplification: ["interface", "dictionary"].includes(parsed_idl.type) would do the trick here too.
There was a problem hiding this comment.
lol. tried 'contains' and fell back to something I knew. Changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5714
This change is