Serialize font shorthand like any other shorthand #10270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 2, 2018
Build PASSEDStarted: 2018-04-03 03:09:37 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-989834
branch
from
b167058
to
c14e0e9
Compare
The font shorthand had a short-circuit in StylePropertySerializer, which meant that it was never serialized as a shorthand for style.cssText, citing reasons of web incompatibility. However, it appears that all other major browsers serialize font as a shorthand instead of having style.cssText expand to all properties. Remove this short-circuit to match other browsers. Bug: 827921 Change-Id: I4d522b41a6153808b6b8dab17831afdd8315fdc3 Reviewed-on: https://chromium-review.googlesource.com/989834 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547607}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-989834
branch
from
c14e0e9
to
238bd03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The font shorthand had a short-circuit in StylePropertySerializer, which
meant that it was never serialized as a shorthand for style.cssText,
citing reasons of web incompatibility. However, it appears that all
other major browsers serialize font as a shorthand instead of having
style.cssText expand to all properties. Remove this short-circuit to
match other browsers.
Bug: 827921
Change-Id: I4d522b41a6153808b6b8dab17831afdd8315fdc3
Reviewed-on: https://chromium-review.googlesource.com/989834
Commit-Queue: Chris Nardi cnardi@chromium.org
Reviewed-by: Timothy Loh timloh@chromium.org
Cr-Commit-Position: refs/heads/master@{#547607}