Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLHttpRequest fixes #555

Closed

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Jan 23, 2014

Added some missing testharnessreport.js.
Fixed tests that may timeout (hopefully without changing the behavior of the tests)

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/623

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@sideshowbarker
Copy link
Contributor

@youennf there are review comments waiting for your responses over at https://critic.hoppipolla.co.uk/r/623

For example, https://critic.hoppipolla.co.uk/showcomment?chain=1573

@sideshowbarker
Copy link
Contributor

Closing this per comment from @youennf over at https://critic.hoppipolla.co.uk/showcomment?chain=5597

"After a quick check, most of the proposed changes are already integrated into the w3c repo. This request should probably be closed. I will make another one for the remaining bits if needed."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants