Move Microsoft's DOM Events tests into position. #56

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

Ms2ger commented Apr 4, 2013

No description provided.

Member

travisleithead commented Apr 17, 2014

Hey! I want to get my feet wet reviewing tests. Since this PR is some of Microsoft's old test submissions (and these tests need some help), I thought I'd start here. Do you mind if I file a bunch of issues? Alternately, I'd be happy to code up the fixes for these as well.

Ms2ger closed this Apr 18, 2014

Ms2ger reopened this Apr 18, 2014

Contributor

Ms2ger commented Apr 18, 2014

Hi @travisleithead—I'd suggest using critic to review this PR: https://critic.hoppipolla.co.uk/r/33

Owner

sideshowbarker commented Jun 2, 2014

Hi @travisleithead—I'd suggest using critic to review this PR: https://critic.hoppipolla.co.uk/r/33

@travisleithead this PR seems to still be waiting your review

Member

travisleithead commented Jun 2, 2014

Yep--I've been directing my energy into locking down DOM L3 Events, which interestingly, is moving some of the generic event dispatch stuff out of the spec, so that its only defined in terms of DOM4 (not both in DOM4 and in DOML3 Events). Since that work will have an impact on what needs to be tested for DOM L3 Events and what tests needs to be moved under DOM, I've been holding off on this.

Contributor

Ms2ger commented Feb 24, 2015

I don't expect us to use this PR for anything at this point.

Ms2ger closed this Feb 24, 2015

sideshowbarker deleted the submission/Microsoft/DOMEvents branch Jun 18, 2015

@jgraham jgraham added a commit that referenced this pull request Apr 13, 2017

@jgraham jgraham Merge pull request #56 from w3c/handlers_class_fixup
fixup! Eliminate constructs that prevent passing routes across processes...
a22d546

@jgraham jgraham pushed a commit that referenced this pull request Apr 13, 2017

@Ms2ger Ms2ger Merge pull request #56 from w3c/jgraham/wdspec_fixup
Fix reading of wdspec items in manifest; r=Ms2ger
de64840

@jgraham jgraham added a commit that referenced this pull request Apr 21, 2017

@jgraham jgraham Merge pull request #56 from w3c/jgraham/path_parsing
Split test_path parsing into its own function.
875c860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment